From fea23160a13e22f4b7fb70868b2cc06dbffe53d2 Mon Sep 17 00:00:00 2001 From: Osei Fortune Date: Sun, 4 Oct 2026 02:34:11 -0400 Subject: [PATCH] ci(release): stop expecting sbg in the classic framework template/build.ps1 no longer builds sbg (removed in #21: the bridge emits JS subclass types at runtime), so the output check failed the classic build on the missing sbg-x64/arm64.exe. --- .github/workflows/npm_release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/npm_release.yml b/.github/workflows/npm_release.yml index b13a87b..b5c4179 100644 --- a/.github/workflows/npm_release.yml +++ b/.github/workflows/npm_release.yml @@ -43,7 +43,7 @@ permissions: # runtime DLL staged as framework/libs//nativescript.dll: # # classic `template/build.ps1` builds the workspace `nativescript` cdylib (rusty_v8) for x64 and -# arm64, release and devtools, rebuilds the tools (dotnet-tool, nsbundle_pack, sbg, +# arm64, release and devtools, rebuilds the tools (dotnet-tool, nsbundle_pack, # typings-generator, ManifestMerger, dotnet-typings-gen) and stages it all under # template/framework. Published from template/ as @nativescript/windows. # variant `template/build.ps1 -Engine ` copies the shared scaffolding out of @@ -232,7 +232,7 @@ jobs: foreach ($arch in $archs) { $expected += (Join-Path $libs "$arch/nativescript.dll") $expected += (Join-Path $libs "devtools/$arch/nativescript.dll") - foreach ($tool in @('dotnet-tool', 'nsbundle_pack', 'sbg', 'typings-generator')) { + foreach ($tool in @('dotnet-tool', 'nsbundle_pack', 'typings-generator')) { $expected += (Join-Path $tools "$tool-$arch.exe") } }