Repository navigation
index: three missing lookup indexes made large-repo queries and warm take minutes - #1847
Merged
Merged
Conversation
…hrough an index Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
October 1, 2026 20:46
swapnilpaliwal-sd
enabled auto-merge
October 1, 2026 20:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a large Java repository the first query after indexing took minutes, and the warm step after a build took more than 20 minutes on one core, holding the build lock. Three lookups had no index, so every per-call-site or per-test query scanned the whole table:
symbolsbyid(the stub-site check of the fact export)refsbyfileandline(the servlet-filter join run on every path and impact query, and by the edit hooks)literalsbyfileandline(the same join's request check)The index now creates all three. Measured on a repository with 8,619 Java files and 97k symbols:
pathqueryThe Java cases pass (329 of 329). The indexes take under a second to create and are additive.