Repository navigation
context: export the graph's facts before reading its edges - #1849
Merged
Merged
Conversation
…k names the error Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
index now warms impact's facts in the background, so a query can arrive before edge.facts exists. context never exported them and died on a missing file. Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
changed the title
swapnilpaliwal-sd
marked this pull request as ready for review
October 2, 2026 20:08
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
October 2, 2026 20:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since index started warming impact's facts in the background,
contextcould run beforeedge.factsexisted. It never exported the facts itself, so it died on a missing file. This failedengine (typescript)on 0.1.9 with two different cases.G.edges()now exports first, which costs nothing when the facts are already stamped.Also: a failing case now prints the tail of its output too, so a traceback shows the error line.
Checked: reproduced by deleting
out/dlafter index (FileNotFoundError), fixed after the change; TypeScript cases 225/225, Python cases 287/287, latency and freshness pass.