Repository navigation
Generate Images in C# Using SkiaSharp: net10.0, SkiaSharp 4.153.1, tests run in CI - #2263
Merged
vladimir-pecanac-main merged 2 commits intoOct 6, 2026
Conversation
- Retarget both projects to net10.0; SkiaSharp 2.88.8 to 4.153.1. - Rename SkiaSharpLibraryLiveTest to ImageServiceTests so the CI filter on "Live" stops skipping all of its tests, and add SkiaSharp.NativeAssets.Linux to the test project in the same commit, because the SkiaSharp package ships no Linux native binary. - DrawSquareOnImage accepts a square at coordinate 0 (the top-left corner is a valid pixel); a zero or negative size is still rejected. - CreateBlankImage validates its dimensions and throws ArgumentException, so the test of that name asserts the type it names. - Two tests added: a square at the origin, and the layout of a fresh SKBitmap (color type, alpha type, stride, buffer size). - Test packages: Microsoft.NET.Test.Sdk 18.10.1, coverlet.collector 10.1.0, xunit 2.9.3, xunit.runner.visualstudio 4.0.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample for https://code-maze.com/csharp-generate-images-using-skiasharp/ (folder csharp-images/GenerateImagesInCSharpUsingSkiaSharp only).
Changes:
Packages (re-queried on NuGet 2026-10-04, newest listed stable):
Local: dotnet build -c Release 0 warnings, 0 errors; dotnet test 10 passed, 0 failed (SDK 10.0.302, runtime 10.0.10, Windows). dotnet list package --vulnerable --include-transitive: none.