Repository navigation
fix(server): drop writable from host grant results - #762
Open
hahahahahayesyeseys wants to merge 1 commit into
Open
hahahahahayesyeseys wants to merge 1 commit into
hahahahahayesyeseys wants to merge 1 commit into
Conversation
hahahahahayesyeseys
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso,
mxmzb and
tylerslaton
as code owners
October 9, 2026 03:14
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Host folder grants are always read-only. Write operations and commands that can edit files are approved separately by the desktop, so the server does not track a writable access mode on a grant.
The desktop result parser nevertheless declared a
writablefield and normalized it into every accepted grant result. The broker immediately discarded that field, which made the server contract imply an access mode it never stored or enforced.This removes
writablefromHostAccessDesktopResultand from the normalized grant object. Extra fields from an older desktop result remain harmless: the parser accepts the result but keeps only the opaque grant id and display name. The broker test now constructs that actual grant shape, and a focused regression test pins the parser output so the field cannot be reintroduced implicitly.Fixes #735.
Where it runs
This is the server boundary that parses a desktop host-access result. It changes no runtime authorization decision: folder grants remain read-only, while write and writable-command requests still go through the existing native per-operation approval path.
grant.writable. No database or durable format changes.Boundary and audit
writablevalue is discarded rather than recorded or used.Changelog
Proof
With the regression test added against
4773ef6before the source change:With the fix:
The repository checks are also clean:
No screenshot is applicable because there is no UI or deployment-visible behavior change.