Skip to content

feat: add explicit kwargs to all trainable - #388

Merged
stephantul merged 2 commits into
mainfrom
add-explicit-kwargs
Oct 5, 2026
Merged

stephantul merged 2 commits into
mainfrom
add-explicit-kwargs

Conversation

@stephantul

Copy link
Copy Markdown
Contributor

This PR adds explicit kwargs to from_pretrained and from_static_model for all trainable classes. This is done to make them a lot easier to use.

@greptile-apps

greptile-apps Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[Medium risk] Refactors model loading to use explicit keyword arguments.

The PR should not merge until inherited loading remains compatible with subclasses that override from_static_model.

Reviews (1) · Last reviewed commit: "feat: add explicit kwargs to all trainab..."

@codecov

codecov Bot commented Oct 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
model2vec/train/base.py 99.56% <100.00%> (+0.01%) ⬆️
model2vec/train/classifier.py 100.00% <100.00%> (+1.57%) ⬆️
model2vec/train/pairs.py 100.00% <100.00%> (ø)
model2vec/train/similarity.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread model2vec/train/base.py
Comment thread model2vec/train/classifier.py
Comment thread model2vec/train/base.py Outdated
@stephantul
stephantul merged commit 969a2d3 into main Oct 5, 2026
11 checks passed
@stephantul
stephantul deleted the add-explicit-kwargs branch October 5, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant