fix(runtime): deliver a posted undefined as undefined, not null - #2063
Draft
adrian-niculescu wants to merge 1 commit into
Draft
adrian-niculescu wants to merge 1 commit into
adrian-niculescu wants to merge 1 commit into
Conversation
Every delivery path built its MessageEvent through the public constructor, whose init dictionary turns an undefined data into null. Delivery now goes through an internal factory that stores the payload as given. The native messageerror paths pass null so that event keeps its default data, and a worker's messageerror carries the deserialization failure as its data, as a port's already does.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
postMessage(undefined)arrives asnulleverywhere a message is delivered: a MessagePort, a BroadcastChannel, a Worker and its global scope, and anode:worker_threadsparentPort. Node and browsers deliverundefined.Every delivery path builds its event with
new MessageEvent(type, { data, ports }), and the constructor's init dictionary turns an undefineddataintonull, as Web IDL requires. Delivery now goes through an internalcreateMessageEventthat stores the payload as given, the same fix as NativeScript/ios#477. The nativemessageerrorpaths passnullinstead ofundefined, so that event keeps its default. A worker'smessageerrornow carries the deserialization failure as itsdata, as a port's already does and as NativeScript/ios#489 does on iOS.Stacked on #2043. The new specs in
testMessaging.jsfail on that branch and pass with this change, and the full device suite passes.