Repository navigation
docs(readme): show measured coverage on the badge - #1583
Merged
Merged
Conversation
The CLI package is published as socket, but three constant tests still expected the old @socketsecurity/cli name and failed on every run.
The README coverage badge still showed the n/a placeholder because it was never generated from a coverage run. Regenerate it from a full pnpm run cover pass: 93% line coverage.
Atakan Solak (mapleleafu)
marked this pull request as draft
October 6, 2026 19:26
Atakan Solak (mapleleafu)
marked this pull request as ready for review
October 6, 2026 19:31
Atakan Solak (mapleleafu)
enabled auto-merge (squash)
October 6, 2026 19:32
Ross Snyder (beamrider9)
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README coverage badge always showed
n/a. That is the placeholder the fleet template seeds. It was never generated from a coverage run in this repo.This PR runs
pnpm run coverand regenerates the badge withscripts/fleet/gen/coverage-badge.mts. Measured line coverage is 93% (statements 93.22%, branches 86.24%, functions 94.75%, lines 93.28%).Three constant tests still expected the old
@socketsecurity/clipackage name. The package is now published assocket, so these tests failed on every run. They now expectsocket.Before / after
main)The README loads the badge from
HEAD, so the rendered README shows 93% only after merge. The images above are pinned to each commit.Notes
test/repotests failed in the local run because of environment differences (pnpm onPATH, fleet bundle version). Their failures can only lower the measured number.Note
Low Risk
Documentation and test expectation updates only; no runtime or API behavior changes.
Overview
Replaces the README coverage badge placeholder (
n/a) with a 93% badge generated from a realpnpm run coverrun, and bumps the README image cache-buster query param soHEADpicks up the newassets/repo/coverage.svg.Aligns three unit tests (
constants-barrel,constants-root-barrel,constants/packages) soSOCKET_CLI_PACKAGE_NAMEis expected to besocketinstead of the obsolete@socketsecurity/cli, matching the published package name and unblocking coverage runs that execute the full test suite.Reviewed by Cursor Bugbot for commit 9d98324. Configure here.