Skip to content

refactor(heap): remove redundant TypeVar in Heap - #15504

Open
iosayin wants to merge 2 commits into
TheAlgorithms:masterfrom
iosayin:refactor/modernize-heap-pep695
Open

iosayin wants to merge 2 commits into
TheAlgorithms:masterfrom
iosayin:refactor/modernize-heap-pep695

Conversation

@iosayin

@iosayin iosayin commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Removes redundant TypeVar import and definition in data_structures/heap/heap.py, relying on Python 3.12+ PEP 695 generic class parameter syntax class Heap[T: Comparable]:. Also aligns Comparable.__gt__ signature with standard Protocol style.

Reference: #15234

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Comment thread data_structures/heap/heap.py Outdated
class Comparable(Protocol):
@abstractmethod
def __gt__(self: T, other: T, /) -> bool:
def __gt__(self, other: object, /) -> bool:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change. We want both self and other to be of type T.

@algorithms-keeper algorithms-keeper Bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 5, 2026
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 5, 2026
@iosayin

iosayin commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

Reverted the Comparable.__gt__ signature back to self: T, other: T as requested. Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants