Conversation
This was referenced Oct 5, 2026
cclauss
requested changes
Oct 5, 2026
| class Comparable(Protocol): | ||
| @abstractmethod | ||
| def __gt__(self: T, other: T, /) -> bool: | ||
| def __gt__(self, other: object, /) -> bool: |
Member
There was a problem hiding this comment.
Please revert this change. We want both self and other to be of type T.
Contributor
Author
|
Reverted the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Removes redundant
TypeVarimport and definition indata_structures/heap/heap.py, relying on Python 3.12+ PEP 695 generic class parameter syntaxclass Heap[T: Comparable]:. Also alignsComparable.__gt__signature with standard Protocol style.Reference: #15234
Checklist