Skip to content

Type stalin sort for any comparable items - #15535

Open
shad0w0P wants to merge 1 commit into
TheAlgorithms:masterfrom
shad0w0P:stalin-sort-comparable-typing
Open

shad0w0P wants to merge 1 commit into
TheAlgorithms:masterfrom
shad0w0P:stalin-sort-comparable-typing

Conversation

@shad0w0P

@shad0w0P shad0w0P commented Oct 6, 2026

Copy link
Copy Markdown

Part of #15234

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?
  • Updated sorts/stalin_sort.py to support any comparable items via a Comparable protocol.
  • Added type parameters and updated signature to def stalin_sort[T: Comparable](<sequence: list[T]>) -> list[T].
  • Added doctests for floats, strings, and testing TypeError on mixed incomparable types.
  • Added complexity analysis to docstrings.
  • Added test_stalin_sort_comparable_items to tests/test_sorts.py.

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Part of TheAlgorithms#15234

- Update stalin_sort to support any comparable items using Comparable protocol
- Add doctests for floats, strings, and TypeError handling
- Add test_stalin_sort_comparable_items in tests/test_sorts.py
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 6, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant