Repository navigation
Add support for BinaryReader slices - #8631
Merged
Merged
Conversation
Slices are helpful when parsing a BinaryView that has some embedded substructure that places bounds on the parser (e.g. a section or a segment). Instead of of continually checking for these bounds it's easier to just form a slice over this region and let reads fail.
saagarjha
force-pushed
the
binaryreader_slice
branch
from
October 6, 2026 06:52
498298a to
4b79c07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slices are helpful when parsing a BinaryView that has some embedded substructure that places bounds on the parser (e.g. a section or a segment). Instead of of continually checking for these bounds it's easier to just form a slice over this region and let reads fail.