Repository navigation
fix: support Selenium-decorated page elements - #2452
Merged
mykola-mokhnach merged 1 commit intoOct 7, 2026
Merged
Conversation
dlowzzxx
requested review from
SrinivasanTarget,
mykola-mokhnach,
saikrishna321 and
valfirst
as code owners
September 26, 2026 19:51
Contributor
|
@dlowzzxx Please rebase the PR with master |
dlowzzxx
force-pushed
the
fix/selenium-decorator-2368
branch
from
October 7, 2026 08:44
8b3219e to
f773ead
Compare
Contributor
Author
|
Rebased on |
mykola-mokhnach
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Types of changes
Details
Addresses #2368.
When Selenium's EventFiringDecorator returns an element as an interface proxy, invoking a method declared by Appium's page element class on that receiver throws
IllegalArgumentException. ElementInterceptor now resolves the matching WebElement method when the declaring class is incompatible with the receiver. Compatible receivers keep the original method dispatch.The fallback invokes the decorated receiver instead of unwrapping it, preserving Selenium listener dispatch.
The regression initializes an Appium page field from a Selenium-decorated driver and checks that
click()reaches the original element and its Selenium listener exactly once. After rebasing onto master0f6e5c1d, the test uses Appium's current PageFactory package.Validation on the rebased head with JDK 21, Gradle 9.8.0, and Selenium 4.50.0:
object is not an instance of declaring class.git diff --checkpasses.The full local build is not green because of these reproduced current-base failures. Selenium snapshot and hosted JDK/mobile matrices have not been rerun locally on this new head.
Codex assisted with implementation and validation.