Repository navigation
Conversation
…ish spelling in JSDoc Add isReverificationCanceledError() and keep isReverificationCancelledError() as a deprecated alias. Re-export the new name from the framework errors entry points and switch internal uses to it. Fix British spellings in public JSDoc. Runtime error codes such as reverification_cancelled are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 35ee4de The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
… spellings Vendor the American spelling checker as scripts/american-spelling.mjs, with its test, and run it from pnpm lint and CI as pnpm lint:american-spelling. Public names that can't be renamed outside a major go in EXCEPTIONS. Bare-word external values (GitHub Actions cancelled(), the Electron native 'cancelled' code, the Directory Sync API status, the CSS color grey, native Google messages, French test strings) get ignore-next-line markers. Fix the other 363 offenders with --fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…glish-spelling-db1ff0
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the SDK's public surface to American English spelling, using the first spelling Merriam-Webster lists. This is part of Clerk standardizing on American English, which started in https://github.com/clerk/clerk/pull/3495.
isReverificationCanceledError()to@clerk/shared/errorand theerrorsentry points of@clerk/react,@clerk/nextjs,@clerk/react-router, and@clerk/tanstack-react-start.isReverificationCancelledError()stays as a deprecated alias of the same function, so existing imports keep working. Internal uses now call the new name.cancelSubscriptionItem(),BillingSubscriptionJSON.next_payment,BillingCheckoutTotalsJSON,NeedsReverificationParameters.cancel,currentUser(),buildUrlWithAuth(),fedCmSupport, the Protect loader config, and the appearance logo and social button options.useReverification()example, which imported from@clerk/react/error(the entry point is@clerk/react/errors) and caughtewhile checkingerr.Adds
pnpm lint:american-spelling(scripts/american-spelling.mjs), which runs inpnpm lintand in CI. It's a denylist of British spellings that also splits camelCase and snake_case identifiers, and--fixrewrites what it finds. It skips CHANGELOGs, the lockfile, and the non-en-USlocalizations, which includeen-GBand translations that aren't in English. Its exceptions are the public names listed under "Not changed", the deprecatedisReverificationCancelledErroralias, andariaLabelledByfrom the ARIA spec. Values that are a bare word go through a scopedamerican-spelling-ignore-next-linemarker instead. These are GitHub Actions'cancelled(), the Electron native code'cancelled', the Directory Sync API status'cancelled', the CSS colorgrey, quoted native Google sign-in messages, and French test strings.--fixcleaned up the rest of the repo, 363 spellings in comments, tests, docs, internal names, anden-UScopy. One example is the "Cancelled" Directory Sync status, which now reads "Canceled".Not changed
These values are emitted at runtime or are part of a cross-version contract. Renaming any of them breaks code that compares against the current spelling, so they're candidates for the next major:
reverification_cancelled(ClerkRuntimeErrorcode): apps compareerr.codeagainst it, and older SDKs check for it.passkey_registration_cancelled/passkey_retrieval_cancelled(ClerkRuntimeErrorcodes): apps compare against them across web, Expo, and Electron, and they double asunstable__errorslocalization keys.SIGN_IN_CANCELLED(@clerk/expo-google-signinnative error code and its "User cancelled the sign-in flow" message): apps check the code, and@clerk/expomatches on it; the native modules ship separately from the JS.'cancelled'(PasskeyNativeErrorCodefrom@clerk/electron-passkeys): not exported from a package entry point, but it's the contract between@clerk/electronand the separately versioned native addon, so an older addon would still emit'cancelled'.afterVerificationCancelled(__internal_UserVerificationProps): older@clerk/sharedversions pass it to newer@clerk/uiat runtime.syncStatus__cancelled(localization key): apps that override localization strings use the key by name.Also left alone:
@clerk/localizationsen-GB, CHANGELOGs, and spec terms such asaria-labelledby.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
🤖 Generated with Claude Code