Repository navigation
Conversation
khanhkit
force-pushed
the
fix/copilot-byok-background
branch
from
October 8, 2026 14:52
95c0eb8 to
73f71d6
Compare
Member
|
Thank you for the PR! The reasoning makes sense, but this looks like a significant change. Could we propose this change upstream directly rather than try maintaining it as a patch here? I think the VS Code maintainers would find it valuable as well, since presumably Codespaces has the same problems, or anyone running regular VS Code in the web. |
Author
|
Exact-head VS Code 1.141 verification update:
Upstream Actions run |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8046
Motivation
code-server is a remote IDE, so long-running agent work should be owned by a server-side lifecycle rather than by a browser tab. For direct-capable Copilot Chat BYOK providers, this change lets the remote Agent Host own model execution so an active turn is not tied to renderer/tab lifetime.
Design
syncEphemeralByokModelsdata stays process-memory-only and is centrally redacted before AHP JSONL serialization.Files changed
patches/copilot-background-byok.diffpatches/copilot-agenthost-session-changes.diffpatches/seriesCurrent VS Code 1.141 verification
Current PR head:
73f71d62f4b26c04dd50b595a3837231a1b5b6aaPinned VS Code gitlink:
2a59476c9bfcb90b3ddc372c36762471b7dfad1c(VS Code 1.141)Executed on the 1.141 port:
copilotSessionLauncher.test: 109/109 pass;byokLmBridgeRegistry.test: 11/11 pass;protocolServerHandler.test: 175/175 pass;ahpJsonlLogger.test: 14/14 pass, including the credential-redaction sentinel;AgentHostByokLmHandler: 22/22 pass;AgentHostSessionInputPills: 22/22 pass, including folder -> Session Changes.Exact-head isolated ARM64 release verification is now GREEN for
73f71d62f4b26c04dd50b595a3837231a1b5b6aa: fullbuild:vscodecompleted (includingcore-cidesktop/server/server-web bundles), code-server build completed, release materialized successfully, and a fresh out-of-container checksum verification passed 5897/5897 files. The built runtime reports73f71d62f4b26c04dd50b595a3837231a1b5b6aawith Code1.141.0.GitHub Actions status
Upstream Build run
37796020383was created for exact head73f71d62f4b26c04dd50b595a3837231a1b5b6aa, but GitHub currently reportsaction_requiredwith zero jobs created. The workflow is waiting for the repository's fork-workflow approval; no CI test has executed or failed yet.Historical note
The earlier VS Code 1.140 candidate
95c0eb85d4265925751949f729851901e8e9db0dpassed its isolated build, fork CI, and live background/detach acceptance. Those results are historical evidence only and are not presented as exact-head verification for this 1.141 port.