Repository navigation
Conversation
Replace the onConnectionFailure callback threaded through CoderApi with a BufferedLogger type. ReconnectingWebSocket flushes the logger it already holds, and getLogger() returns the buffered logger so getConnectionLogBuffer() is removed.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies how sockets flush the connection log buffer.
The
onConnectionFailurecallback was threaded from the container throughCoderApi.createinto everyReconnectingWebSocket, even though the logger it flushed was already passed along the same path.BufferedLoggerinterface (Loggerplusflush) inlogger.ts, replacingConnectionLogBuffer.ReconnectingWebSocketandCoderApitake aBufferedLogger, and the socket callsflushdirectly on a terminal failure and once per unreachable outage.getLogger()returns theBufferedLogger, sogetConnectionLogBuffer()is removed.BufferingLogger.onConnectionFailure.No behavior change: the flushed
<reason> <route>strings are identical.🤖 Generated with Claude Code