Repository navigation
feat: say why checks were skipped in the report - #300
Conversation
When commit-check names a reason for a skipped check (an author on an ignore_authors list), the report shows it on each skipped line and in one sentence under the verdict, so a skipped run no longer reads as unexplained. An older CLI that sends no reason renders as before.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughSkipped scopes expose an available reason. Step-log and Markdown output show reasons on skipped-scope labels and include deduplicated reason text in verdicts. Tests cover skipped and passing scopes, aggregate output, and optional reason fields in CLI check data. ChangesSkipped-scope reason reporting
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue was found. Reports retain the older-CLI behavior when no reason is provided. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Commit Check✅ All 6 checks passed Show all 6 checkscommit-check 2.18.3 · Rules reference |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 637 654 +17
=========================================
+ Hits 637 654 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Drop the config section from the verdict sentence so the common bot case reads "Skipped because author dependabot[bot] is in ignore_authors." once; the per-line reasons keep the section. Accept the CLI's new optional reason key in the real-binary contract test.
Requested by Xianpeng · project thread
Before: on #299 the PR comment said "⊘ All 5 checks skipped — nothing was validated" and every line read just "(skipped)". The real cause,
dependabot[bot]being onignore_authorsin the org config, appeared nowhere.After:
The sentence under the verdict drops the config section so the usual bot case is one short reason; the per-line reasons in the collapsed block keep it. The same sentence follows the partial-skip verdict and the step-log verdict. The Action's own shallow-clone author skip now says "the pull request's head commit could not be resolved".
How:
ScopeResult.skip_reasonreads thereasonfield that commit-check/commit-check#605 (merged) adds to--format json. With the current CLI (noreason) the output is unchanged, so this is safe to merge first; the reason shows once a commit-check release with #605 is pinned inrequirements.txt. The real-binary contract test now acceptsreasonas an optional key so that bump stays green.Checked locally: 230 tests pass with 100% coverage of
main.pyagainst commit-check 2.18.3, the contract tests pass against commit-check main, and black and mypy are clean.🤖 Generated with Claude Code
https://claude.ai/code/session_019ik2pnYPYJJ5e3GYGeoPgE
Summary by CodeRabbit