Skip to content

Fix #14769 FP unreadVariable with address in chained assignment of unused variable #8926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −1
Open

Fix #14769 FP unreadVariable with address in chained assignment of unused variable #8926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7de7d8
Update checkunusedvar.cpp
chrchr-github Oct 7, 2026
dddc7c8
Update testunusedvar.cpp
chrchr-github Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/checkunusedvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,7 @@ void CheckUnusedVarImpl::checkFunctionVariableUsage_iterateScopes(const Scope* c
const Token * const equal = skipBracketsAndMembers(tok->next());

// checked for chained assignments
if (tok != start && equal && equal->str() == "=") {
if (tok != start && (Token::simpleMatch(equal, "=") || (start->astParent() && Token::simpleMatch(start->astParent()->astParent(), "=")))) {
const nonneg int varId = tok->varId();
const Variables::VariableUsage * const var = variables.find(varId);

Expand Down
8 changes: 8 additions & 0 deletions test/testunusedvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3370,6 +3370,14 @@ class TestUnusedVar : public TestFixture {
" return a;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:5:14]: (style) Variable 'b[c]' is assigned a value that is never used. [unreadVariable]\n", errout_str());

functionVariableUsage("int f() {\n" // #14769
" int i = 2;\n"
" const int *a, *c;\n"
" a = c = &i;\n"
" return *a;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4:11]: (style) Variable 'c' is assigned a value that is never used. [unreadVariable]\n", errout_str());
}

void localvar24() { // ticket #1803
Expand Down
Loading