Skip to content

Honor disabled timeouts during token refresh - #608

Merged
AndreyVMarkelov merged 2 commits into
dropbox:mainfrom
Shubham-Padkonde:fix/refresh-token-timeout
Oct 7, 2026
Merged

AndreyVMarkelov merged 2 commits into
dropbox:mainfrom
Shubham-Padkonde:fix/refresh-token-timeout

Conversation

@Shubham-Padkonde

Copy link
Copy Markdown
Contributor

A client created with timeout=None documents that requests wait without a socket timeout, but refresh_access_token substitutes DEFAULT_TIMEOUT (100 seconds). Applications that explicitly disable timeouts therefore still time out during token refresh.

Pass the client's stored timeout directly to the refresh POST. The constructor already supplies the default when no override is provided. Regression tests cover None and a numeric override.

Validation: the None case fails before the fix; all 102 unit tests pass afterward. Ruff lint and formatting pass.

@ineil-dbx

Copy link
Copy Markdown

Hi @Shubham-Padkonde, I’ve raised this with our engineering team for further review. They’ll be able to review the pull request and address it as appropriate.

@AndreyVMarkelov
AndreyVMarkelov self-requested a review October 7, 2026 17:28
@AndreyVMarkelov
AndreyVMarkelov merged commit 6c2b9c9 into dropbox:main Oct 7, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants