Repository navigation
Close download responses when opening the destination fails - #609
Merged
AndreyVMarkelov merged 2 commits intoOct 7, 2026
Merged
AndreyVMarkelov merged 2 commits into
AndreyVMarkelov merged 2 commits into
Conversation
|
Hi @Shubham-Padkonde, I’ve raised this with our engineering team for further review. They’ll be able to review the pull request and address it as appropriate. |
AndreyVMarkelov
self-requested a review
October 7, 2026 17:24
AndreyVMarkelov
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the destination file cannot be opened (for example, its parent directory is missing), _save_body_to_file raises before entering the HTTP response's closing context. The unconsumed download response remains open.
Enter the response cleanup context before opening the local file so that file-open failures also release the response. Tests use a real Requests response backed by an urllib3 HTTPResponse and cover both a successful save and a missing destination directory.
Validation: the missing-directory case leaks the stream before the fix; all 102 unit tests pass afterward. Ruff lint and formatting pass.