Skip to content

pre-commit autoupdate - #2526

Merged
sobolevn merged 2 commits into
dry-python:masterfrom
Khabib73:pr/#2525
Oct 6, 2026
Merged

sobolevn merged 2 commits into
dry-python:masterfrom
Khabib73:pr/#2525

Conversation

@Khabib73

@Khabib73 Khabib73 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

refs #2525

Comment thread returns/contrib/hypothesis/laws.py Outdated

@contextmanager
def clean_plugin_context() -> Iterator[None]:
def clean_plugin_context() -> Generator[None, None, None]:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def clean_plugin_context() -> Generator[None, None, None]:
def clean_plugin_context() -> Generator[None]:

why not a shorter version?

@Khabib73 Khabib73 Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generator[None] is invalid for Python <= 3.12. Default type arguments were only introduced in Python 3.13? https://docs.astral.sh/ruff/rules/unnecessary-default-type-args/

@codspeed

codspeed Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 22 untouched benchmarks


Comparing Khabib73:pr/#2525 (7247ff6) with master (837f1ce)

Open in CodSpeed

@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (82ef3ef) to head (7247ff6).
⚠️ Report is 623 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #2526    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           80        81     +1     
  Lines         2485      2564    +79     
  Branches       437        44   -393     
==========================================
+ Hits          2485      2564    +79     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Khabib73

Khabib73 commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author

2 workflows awaiting approval 😐

Does CI always require manual approval?

I've enrolled in a type theory course and I'm also planning to contribute more frequently to dry-python :) Could you please grant me write access to the repo so CI runs automatically on my PRs? It would really save you from having to manually approve them each time. Thanks!

@sobolevn
sobolevn merged commit 1739834 into dry-python:master Oct 6, 2026
26 checks passed
@sobolevn

sobolevn commented Oct 6, 2026

Copy link
Copy Markdown
Member

Done, now your PRs will not require any manual actions :)
Thanks!

@Khabib73
Khabib73 deleted the pr/#2525 branch October 6, 2026 16:08
@Khabib73

Khabib73 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants