Repository navigation
pre-commit autoupdate - #2526
Conversation
|
|
||
| @contextmanager | ||
| def clean_plugin_context() -> Iterator[None]: | ||
| def clean_plugin_context() -> Generator[None, None, None]: |
There was a problem hiding this comment.
| def clean_plugin_context() -> Generator[None, None, None]: | |
| def clean_plugin_context() -> Generator[None]: |
why not a shorter version?
There was a problem hiding this comment.
Generator[None] is invalid for Python <= 3.12. Default type arguments were only introduced in Python 3.13? https://docs.astral.sh/ruff/rules/unnecessary-default-type-args/
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2526 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 80 81 +1
Lines 2485 2564 +79
Branches 437 44 -393
==========================================
+ Hits 2485 2564 +79 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Does CI always require manual approval? I've enrolled in a type theory course and I'm also planning to contribute more frequently to dry-python :) Could you please grant me write access to the repo so CI runs automatically on my PRs? It would really save you from having to manually approve them each time. Thanks! |
|
Done, now your PRs will not require any manual actions :) |
|
Thanks! |
refs #2525