Repository navigation
fix(security): close SQL injection in tree sort, TV filters and identifier quoting - #2490
Merged
Merged
Conversation
…ifier quoting Allowlist the manager tree sort column/direction, escape TV name lists, quote column names and aliases in Database insert/update, and validate TV filter/sort tokens that reach raw SQL. A malformed TV filter now matches nothing instead of being dropped. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…SE_PATH Resolve the repository root four levels up and create the assets directory when another test already defined EVO_BASE_PATH as core/. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…rocess isolation Pest cannot start RunTestsInSeparateProcesses children, so the scenario moves to a fixture script that evoRunPhp() launches, like the discovery test. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ars fields Limit the number of TV filters (fail closed) and sort terms per call via SiteContent::MAX_TV_QUERY_TERMS, validate the getTemplateVars field list like getDocumentChildrenTVars, and drop the redundant length checks and the duplicate tree sort normalization in the manager ajax endpoint. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowlist the manager tree sort column/direction, escape TV name lists, quote column names and aliases in Database insert/update, and validate TV filter/sort tokens that reach raw SQL. A malformed TV filter now matches nothing instead of being dropped.