Fix searching for standalone symbolic entries - #2747
Open
Ethereal49 wants to merge 1 commit into
Open
Ethereal49 wants to merge 1 commit into
Ethereal49 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searching Clojure for
->normalizes both the entry name and query to., which is then rejected as a separator-only query. Preserve a standalone symbolic name when separator normalization would consume the entire name, after stripping the existing decorations. Compound names still use the existing separator normalization and ranking rules.Fixes #817.
Added regression coverage for standalone symbols, decorated symbolic names, Clojure operators, member separators, namespaces, exact/fuzzy ranking, and the existing suppression of empty and dot-only queries. The new regressions fail on the original searcher.
Validation:
npm test: 47 passed, no skipped tests.npm run typecheck: passed for assets and tests.->match afterward through the actual Entry/Search/asynchronous Searcher modules in an isolated browser harness.->becoming searchable and-additionally matching that entry changed; existing separator queries and relative ranking remained consistent.The full Sinatra/Ruby app and Ruby suite were not run because the local Ruby/Bundler versions do not meet the repository requirements. The browser check used an isolated module harness with test replacements for generated config/templates, rather than the full site. Existing
.and..query suppression is unchanged.Prepared with OpenAI Codex assistance; the automated tests, typechecks and isolated browser checks above were performed locally.