Skip to content

test(asgi, asyncio, aws_lambda): Remove redundant empty data_collection from sentry_init #7906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericapisani wants to merge 1 commit into from
+0 −26
Open

test(asgi, asyncio, aws_lambda): Remove redundant empty data_collection from sentry_init #7906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions tests/integrations/asgi/test_asgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,6 @@ async def test_capture_transaction(
capture_items,
):
sentry_init(
data_collection={},
traces_sample_rate=1.0,
)
app = SentryAsgiMiddleware(asgi3_app)
Expand Down Expand Up @@ -225,7 +224,6 @@ async def test_capture_transaction_with_error(
capture_items,
):
sentry_init(
data_collection={},
traces_sample_rate=1.0,
)

Expand Down Expand Up @@ -403,7 +401,6 @@ async def test_websocket(
capture_items,
):
sentry_init(
data_collection={},
traces_sample_rate=1.0,
)

Expand Down Expand Up @@ -444,7 +441,6 @@ async def test_auto_session_tracking_with_aggregates(
sentry_init, asgi3_app, capture_envelopes
):
sentry_init(
data_collection={},
traces_sample_rate=1.0,
)
app = SentryAsgiMiddleware(asgi3_app)
Expand Down Expand Up @@ -490,7 +486,6 @@ async def test_fallback_segment_name_and_source(
capture_items,
):
sentry_init(
data_collection={},
traces_sample_rate=1.0,
)
app = SentryAsgiMiddleware(asgi3_app)
Expand Down
15 changes: 0 additions & 15 deletions tests/integrations/asyncio/test_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ async def test_create_task(
):
sentry_init(
traces_sample_rate=1.0,
data_collection={},
integrations=[AsyncioIntegration()],
)

Expand Down Expand Up @@ -118,7 +117,6 @@ async def test_gather(
):
sentry_init(
traces_sample_rate=1.0,
data_collection={},
integrations=[AsyncioIntegration()],
)

Expand Down Expand Up @@ -156,7 +154,6 @@ async def test_exception(
):
sentry_init(
traces_sample_rate=1.0,
data_collection={},
integrations=[AsyncioIntegration()],
)

Expand Down Expand Up @@ -184,7 +181,6 @@ async def test_exception(
async def test_task_result(sentry_init):
sentry_init(
integrations=[AsyncioIntegration()],
data_collection={},
)

async def add(a, b):
Expand All @@ -202,7 +198,6 @@ async def test_task_with_context(sentry_init):
"""
sentry_init(
integrations=[AsyncioIntegration()],
data_collection={},
)

var = ContextVar("var")
Expand Down Expand Up @@ -374,7 +369,6 @@ async def test_span_origin(
sentry_init(
integrations=[AsyncioIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

items = capture_items("span")
Expand Down Expand Up @@ -408,7 +402,6 @@ async def test_task_spans_false(
sentry_init(
traces_sample_rate=1.0,
integrations=[AsyncioIntegration(task_spans=False)],
data_collection={},
)

items = capture_items("span")
Expand Down Expand Up @@ -441,7 +434,6 @@ async def test_enable_asyncio_integration_with_task_spans_false(

sentry_init(
traces_sample_rate=1.0,
data_collection={},
)

assert "asyncio" not in sentry_sdk.get_client().integrations
Expand Down Expand Up @@ -473,7 +465,6 @@ async def test_delayed_enable_integration(
):
sentry_init(
traces_sample_rate=1.0,
data_collection={},
)

assert "asyncio" not in sentry_sdk.get_client().integrations
Expand Down Expand Up @@ -514,7 +505,6 @@ async def test_delayed_enable_integration(
async def test_delayed_enable_integration_with_options(sentry_init):
sentry_init(
traces_sample_rate=1.0,
data_collection={},
)

assert "asyncio" not in sentry_sdk.get_client().integrations
Expand Down Expand Up @@ -545,7 +535,6 @@ async def test_delayed_enable_enabled_integration(sentry_init, uninstall_integra
sentry_init(
integrations=[integration],
traces_sample_rate=1.0,
data_collection={},
)

assert "asyncio" in sentry_sdk.get_client().integrations
Expand Down Expand Up @@ -573,7 +562,6 @@ async def test_delayed_enable_integration_after_disabling(
sentry_init(
disabled_integrations=[AsyncioIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

assert "asyncio" not in sentry_sdk.get_client().integrations
Expand Down Expand Up @@ -620,7 +608,6 @@ async def test_internal_tasks_not_wrapped(
sentry_init(
integrations=[AsyncioIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

async def user_task():
Expand Down Expand Up @@ -662,7 +649,6 @@ async def internal_task():
def test_loop_close_patching(sentry_init):
sentry_init(
integrations=[AsyncioIntegration()],
data_collection={},
)

loop = asyncio.new_event_loop()
Expand All @@ -689,7 +675,6 @@ def test_loop_close_flushes_async_transport(sentry_init):

sentry_init(
integrations=[AsyncioIntegration()],
data_collection={},
)

# Save the current event loop to restore it later
Expand Down
1 change: 0 additions & 1 deletion .../integrations/aws_lambda/lambda_functions_with_embedded_sdk/BasicOkSpanStreaming/index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

sentry_sdk.init(
dsn=os.environ.get("SENTRY_DSN"),
data_collection={},
traces_sample_rate=1.0,
integrations=[AwsLambdaIntegration()],
)
Expand Down
1 change: 0 additions & 1 deletion ...ions/aws_lambda/lambda_functions_with_embedded_sdk/RaiseErrorPerformanceDisabled/index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

sentry_sdk.init(
dsn=os.environ.get("SENTRY_DSN"),
data_collection={},
traces_sample_rate=None, # this is the default, just added for clarity
integrations=[AwsLambdaIntegration()],
)
Expand Down
1 change: 0 additions & 1 deletion ...tions/aws_lambda/lambda_functions_with_embedded_sdk/RaiseErrorPerformanceEnabled/index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

sentry_sdk.init(
dsn=os.environ.get("SENTRY_DSN"),
data_collection={},
traces_sample_rate=1.0,
integrations=[AwsLambdaIntegration()],
)
Expand Down
1 change: 0 additions & 1 deletion ...tegrations/aws_lambda/lambda_functions_with_embedded_sdk/RaiseErrorSpanStreaming/index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

sentry_sdk.init(
dsn=os.environ.get("SENTRY_DSN"),
data_collection={},
traces_sample_rate=1.0,
integrations=[AwsLambdaIntegration()],
)
Expand Down
1 change: 0 additions & 1 deletion ...grations/aws_lambda/lambda_functions_with_embedded_sdk/TimeoutErrorScopeModified/index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

sentry_sdk.init(
dsn=os.environ.get("SENTRY_DSN"),
data_collection={},
traces_sample_rate=1.0,
integrations=[AwsLambdaIntegration(timeout_warning=True)],
)
Expand Down
1 change: 0 additions & 1 deletion tests/integrations/aws_lambda/lambda_functions_with_embedded_sdk/TracesSampler/index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ def trace_sampler(sampling_context):

sentry_sdk.init(
dsn=os.environ.get("SENTRY_DSN"),
data_collection={},
traces_sample_rate=1.0,
traces_sampler=trace_sampler,
integrations=[AwsLambdaIntegration()],
Expand Down
Loading