Repository navigation
Fix identity field mappings deleting log record fields - #170
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RenamerPlugin(msg="msg")deletes the message field: it first assigns the value to the same key and then deletes that key. Formatting the resulting record raisesAttributeErrorinstead of producing the log message.Pop the source value before assigning the destination so identity mappings preserve the field. Both strict and non-strict modes have regression coverage. Existing missing-field and ordinary rename behavior is unchanged. Includes the patch version bump required by the contribution guide.
Validation: 78 tests pass with 100% coverage; Ruff and Pyright pass. Both new regression cases fail before the fix.