Repository navigation
fix(workflows): load custom steps before update - #4768
Open
WOLIKIMCHENG wants to merge 2 commits into
Open
WOLIKIMCHENG wants to merge 2 commits into
WOLIKIMCHENG wants to merge 2 commits into
Conversation
mnriem
added
the
triage-nice-to-have
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Process-global custom steps can leak across projects and incorrectly validate an update.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Loads custom workflow steps before validating workflow updates.
Changes:
- Registers project custom steps during
workflow update. - Adds success and transactional rejection regressions.
| File | Description |
|---|---|
src/specify_cli/workflows/command_update.py |
Loads custom steps before update validation. |
tests/specify_cli/workflows/test_command_update.py |
Tests custom and unknown step updates. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| from .catalog import WorkflowCatalog, WorkflowCatalogError | ||
|
|
||
| project_root = cli._require_specify_project() | ||
| load_custom_steps(project_root) |
Collaborator
|
Please address Copilot feedback |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix is consistent with existing workflow commands and has comprehensive regression coverage.
1 open finding
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Collaborator
|
Please address Copilot feedback |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Load project-installed custom workflow steps before
workflow updatevalidates downloaded candidates. This aligns update with add, run, and resume while using the active project's custom-step registry.The update path now refreshes project-local custom steps between projects, so a type from one project is not accepted when updating another. Invalid updates continue to leave the installed workflow and registry unchanged.
Testing
tests/specify_cli/workflows/test_command_update.pyandtest_custom_steps.py: 24 passedtests/specify_cli/workflows: 588 passed, 1 skippedtests/test_workflows.py: 779 passedgit diff --check origin/main