Repository navigation
Conversation
nickrolfe
added
the
Complexity: Medium
nickrolfe
force-pushed
the
nickrolfe/model-editor-json
branch
2 times, most recently
from
October 2, 2026 16:19
c2e2ac2 to
8d067e1
Compare
This will allow us, for example, to switch to JSON as the default format while keeping existing YAML files as YAML. JSON (de)serialization is currently stubbed out, and will be implemented in a follow-up commit.
Update the `dataExtensions` entry that it adds when writing a pack manifest to include `models/**/*.json`, in addition to the existing `models/**/*.yml`.
nickrolfe
force-pushed
the
nickrolfe/model-editor-json
branch
from
October 5, 2026 11:32
8d067e1 to
4afeaf8
Compare
nickrolfe
added this pull request to stack #4584
October 7, 2026 09:46
nickrolfe
marked this pull request as ready for review
October 7, 2026 09:48
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Filename grouping can leave stale models active or overwrite existing models.
Review effort: Balanced
Findings: None
What changed in this PR
Adds JSON data-extension support to the model editor while keeping YAML as the default for new files.
Changes:
- Adds format-aware loading and saving that preserves existing file formats.
- Updates new-pack metadata and generated-file handling for JSON.
- Extends tests and release notes.
| File | Description |
|---|---|
| extensions/ql-vscode/test/vscode-tests/no-workspace/model-editor/extension-pack-picker.test.ts | Updates expected pack globs. |
| extensions/ql-vscode/test/vscode-tests/cli-integration/model-editor/modeled-method-fs.test.ts | Adds a generated JSON fixture. |
| extensions/ql-vscode/test/unit-tests/model-editor/extension-serialization.test.ts | Tests parsing, serialization, and format preservation. |
| extensions/ql-vscode/src/model-editor/modeled-method-fs.ts | Uses format-aware persistence and filters generated JSON. |
| extensions/ql-vscode/src/model-editor/model-editor-view.ts | Updates generated-model serialization. |
| extensions/ql-vscode/src/model-editor/languages/models-as-data.ts | Documents JSON generated-file naming. |
| extensions/ql-vscode/src/model-editor/extension-serialization.ts | Implements JSON support and format-aware filename grouping. |
| extensions/ql-vscode/src/model-editor/extension-pack-picker.ts | Includes JSON globs in new packs. |
| extensions/ql-vscode/CHANGELOG.md | Announces JSON support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support to the model editor for loading JSON-formatted data extensions, in addition to the existing YAML format. When saving and overwriting existing extensions, it will preserve the file's existing format.
For now, new files will still be saved as YAML. We can change the definition of
DEFAULT_EXTENSION_FORMAT_FOR_NEW_FILESto switch to JSON when we're ready.I have done some manual testing: