Push the release tag and draft a GitHub release from the release workflow - #828
Merged
Merged
Conversation
…flow The tag created by github-build.sh was never pushed, so GitHub tags were created by hand at master HEAD and pointed at post-release SNAPSHOT commits. Push it, open a draft release on it, and fail before deploying if the pom version isn't a SNAPSHOT. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-build.shtagged the release commit locally but never pushed the tag, andcreate-pull-requestonly pushes the branch. So the wiki's "create a release from the tag that was just created" step had no tag to use, and v14.0.0, v14.0.1 and v14.0.3 ended up tagged by hand at master HEAD, on the post-release SNAPSHOT commits.v<version>right after the release commit, then create a draft GitHub release on it with generated notes. Notes start at the current Latest release, because release tags sit on the PR side of the merge and GitHub otherwise falls back to v14.0.3. If creating the draft fails, it only logs a warning so the bump PR still gets opened.-SNAPSHOT. Re-running after a release would otherwise try to republish to Central.contents: readfor the workflow,contents: write+pull-requests: writeforpublish.Tested
github-build.shin anubuntu:24.04container with stubbedmvn/ghagainst a local bare remote. The annotated tag reaches the remote on the14.1.1release commit, the bump commit stays local for the PR, a failedgh release createstill produces the bump commit, and a non-SNAPSHOT pom exits beforemvn. actionlint is clean.After merging, the wiki's last step becomes "edit and publish the draft release".
🤖 Generated with Claude Code