fix(css): stop emitting :host-context selectors in global stylesheets - #31516
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30024
What is the current behavior?
Currently,
float-elements.css(andionic.bundle.css/utils.bundle.css, which include it) contains:host-context([dir=rtl]) .ion-float-*selectors from thertl()mixin. Lightning CSS, the default CSS minifier in Vite 8, warns about every one of them. They can never match anyway, because these stylesheets apply to the document, not a shadow root.What is the new behavior?
The
rtl()mixin now skips its:host-contextrule when$rtl-use-host-contextis false, andfloat-elements.scsssets it. The float utilities still flip in RTL through the existing[dir=rtl]and:dir(rtl)rules. Component styles are unchanged, since they still need:host-context. A new spec compiles every global stylesheet and asserts none of them contain:host-context.Does this introduce a breaking change?
Other information
The only output change is 10 removed
:host-contextrules infloat-elements.css, which also come out of the two bundles that include it.Dev build