Conversation
Agent assistance: Codex 🤖🤖.
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MbappeWU
marked this pull request as ready for review
October 4, 2026 20:32
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #756.
The post-propagation consistency checks compare a trait value with
change.neweven when they are still the same object. For values such as pandas DataFrames, inequality produces a non-scalar result and its truth conversion raises, interrupting normal link updates and later observers.Add the protected
_should_updatecomparison hook suggested in the issue. Its default accepts object identity and retains inequality for distinct values. Both consistency checks use the hook, so subclasses can customize comparison without replacing the propagation methods. Existing scalar equality and broken-link detection remain intact.The regressions exercise both directions, observer continuation, equal-but-distinct replacements, custom comparison through actual propagation, and recovery of the updating flag. The guide documents that this is a consistency check after writing the other trait, rather than a condition that suppresses the write.
The upstream Tests run passes all 26 tasks, including Linux/Windows/macOS, PyPy and free-threaded Python, minimum and prerelease dependencies, typing/lint, docs, source-archive installation, the dry-run release check, and all five downstream projects.
Agent assistance: Codex 🤖🤖.