Skip to content

Run Windows and macOS tests weekly - #147

Merged
rcosta358 merged 13 commits into
codex/issue-133-webview-lifecyclefrom
codex/issue-134-platform-tests
Oct 7, 2026
Merged

rcosta358 merged 13 commits into
codex/issue-133-webview-lifecyclefrom
codex/issue-134-platform-tests

Conversation

@rcosta358

@rcosta358 rcosta358 commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Closes #134.

Add weekly and manual Windows/macOS runs for client and server unit tests plus VS Code stable integration tests, with logs uploaded on failure. The diff contains only platform-tests.yml.

Related Issues

Depends on #146. The existing prerequisite PRs now form one chain through #145, #144, #143, #141, #142, #140, #139, #138, and #137 to main. The schedule becomes active when merged to the default branch.

Validation: 32 client tests, 24 server tests, lint, production/test TypeScript checks, and extension installation passed. Stable and minimum VS Code integration passed in PR CI. Fresh Windows/macOS validation passed on the final commit, including both unit-test suites and VS Code integration.

🤖 Generated with Codex

@rcosta358 rcosta358 added the testing Testing related label Oct 2, 2026

@CatarinaGamboa CatarinaGamboa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base branch: this PR targets codex/phase-4-test-base, which has no PR to main and doesn't contain #139 (git merge-base --is-ancestor on #139's branch and phase-4: not an ancestor). Merging here won't get the weekly workflow onto main, and the schedule only runs from the default branch. Once the stack lands, this needs its base changed to main (or to the last PR in the stack), and it should be rebased onto a base that includes #139.

Reviewed with Claude Code (reviewer + adversarial agents per PR, findings checked against the code before posting).

rcosta358 and others added 3 commits October 4, 2026 15:36
Co-authored-by: Codex <noreply@openai.com>

# Conflicts:
#	.github/workflows/test.yml
Co-authored-by: Codex <noreply@openai.com>

# Conflicts:
#	.github/workflows/test.yml
Co-authored-by: Codex <noreply@openai.com>
@rcosta358
rcosta358 changed the base branch from codex/phase-4-test-base to codex/issue-133-webview-lifecycle October 4, 2026 14:39
@rcosta358

Copy link
Copy Markdown
Collaborator Author

Retargeted this PR onto #146, which leads through the stack to main, and merged #139 into the branch (939e85e). The description now lists the additional unit-test dependencies and notes that the schedule activates once it reaches the default branch. Client/server tests, stable integration, and full extension installation passed.

@CatarinaGamboa CatarinaGamboa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the +4009 here is #139, #140, #141 and #142 merged in (vitest specs, server tests, publish.yml, ~2.5k lockfile lines), and #139/#140/#142 conflict with this stack in test.yml, package.json, tsconfig.json, .vscodeignore and package-lock.json. Could we land those into the chain first and rebase this down to just platform-tests.yml? Also, the linked Windows/macOS run predates these merges, so the server/vitest tests have not actually run on those OSes yet.

rcosta358 and others added 2 commits October 6, 2026 23:28
# Conflicts:
#	.github/workflows/test.yml
#	client/package-lock.json
#	client/package.json
#	client/tsconfig.json

Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
@rcosta358

Copy link
Copy Markdown
Collaborator Author

Addressed the oversized diff and outdated platform validation. Restacked the existing prerequisite PRs into the base chain, resolving the shared workflow/package/TypeScript conflicts; this PR now changes only platform-tests.yml (70 added lines).

Fresh Windows/macOS validation passed on final commit 7518175, including the client and server unit tests introduced by the prerequisite PRs. PR checks also passed both stable and minimum VS Code integration.

Independent review, 32 local client tests, 24 server tests, lint, both TypeScript checks, and full extension installation passed. The description now documents the actual dependency chain and current validation.

@rcosta358
rcosta358 added this pull request to stack #148 October 7, 2026 11:17
@rcosta358
rcosta358 merged commit 27fe8f9 into main Oct 7, 2026
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Testing related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scheduled Windows and macOS run

2 participants