Skip to content

Cache one nodebuilder per emit resolver, make emit resolver emit context scoped #64649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wesley Wigham (weswigham) merged 11 commits into from
Oct 6, 2026
Merged

Cache one nodebuilder per emit resolver, make emit resolver emit context scoped #64649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
610e736
Cache one nodebuilder per emit resolver, make emit resolver emit cont…
weswigham Oct 5, 2026
b5f8011
Use links from checker, monitor locks better
weswigham Oct 5, 2026
60e9ff8
Simplify
weswigham Oct 5, 2026
4ef1599
Merge branch 'main' into fix-emitcontext-emitresolver-layers
weswigham Oct 5, 2026
4399701
Rename get->new where apprpriate, cache in the emitHost, and unpool e…
weswigham Oct 6, 2026
38f28de
Quick NewEmitContext usage audit now that its not pooled - move creat…
weswigham Oct 6, 2026
1c48062
And toss in some releases for good measure
weswigham Oct 6, 2026
1d31075
Alright, lets just remove the cache and see if we have perf issues, e…
weswigham Oct 6, 2026
1bc388e
To-done another related TODO and actually relayer all the awkward stuff
weswigham Oct 6, 2026
a5efea3
And hoist construction of emit resolvers up a bit and borrow an emit …
weswigham Oct 6, 2026
234fc09
Move emit arena free a smidge so it applies to declaration emit, too
weswigham Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions tsc/internal/checker/checker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
"github.com/microsoft/TypeScript/tsc/internal/jsnum"
"github.com/microsoft/TypeScript/tsc/internal/module"
"github.com/microsoft/TypeScript/tsc/internal/modulespecifiers"
"github.com/microsoft/TypeScript/tsc/internal/printer"
"github.com/microsoft/TypeScript/tsc/internal/scanner"
"github.com/microsoft/TypeScript/tsc/internal/stringutil"
"github.com/microsoft/TypeScript/tsc/internal/tracing"
Expand Down Expand Up @@ -888,8 +889,7 @@ type Checker struct {
isStringIndexSignatureOnlyType func(*Type) bool
markNodeAssignments func(*ast.Node) bool
compareTypesAssignable TypeComparer
emitResolver *EmitResolver
emitResolverOnce sync.Once
emitResolverLinks EmitResolverLinks
_jsxNamespace string
_jsxFactoryEntity *ast.Node
skipDirectInferenceNodes collections.Set[*ast.Node]
Expand Down Expand Up @@ -32687,12 +32687,8 @@ func (c *Checker) GetTypeAtLocation(node *ast.Node) *Type {
return c.getTypeOfNode(ast.GetReparsedNodeForNode(node))
}

func (c *Checker) GetEmitResolver() *EmitResolver {
c.emitResolverOnce.Do(func() {
c.emitResolver = newEmitResolver(c)
})

return c.emitResolver
func (c *Checker) NewEmitResolver(emitContext *printer.EmitContext) *EmitResolver {
return newEmitResolver(c, emitContext)
}

func (c *Checker) GetAliasedSymbol(symbol *ast.Symbol) *ast.Symbol {
Expand Down
Loading
Loading