Repository navigation
Keep PEP 723 inline script CodeLens live and persistent - #1906
Stella Huang (StellaHuang95) merged 2 commits into
Conversation
7f582fd to
f302aba
Compare
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
|
Result: Verification detailsVerification: Isolated verification observed failures that were not classified as caused by this PR: Batched dependency and test discovery. The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Summary: Offline dependency installation and `npm run compile-tests` succeeded in the container. Targeted inline-script suites passed: 285 common, 214 feature, and 370 manager tests, with 5 manager tests pending. No executed test failed; discovery's Git probes failed because the container checkout lacked Git metadata. The eight new VS Code integration tests could not run because no downloaded VS Code runtime was available. Unit coverage supports the live CodeLens, persistent Ready, validation, and routing behavior, but editor-host verification remains incomplete. Test runs: 5 passed, 1 failed, 1 not run
|
Keep setup available for recognizable inline metadata while preserving diagnostics and validating on invocation. Persist validated ready state, react to live metadata edits, and retain exact-file routing for body-only edits. Add focused unit and VS Code integration coverage plus user-facing documentation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Invalidate pending saved-metadata reads when the live PEP 723 block diverges, preventing an older read from restoring an obsolete exact-file route. Add a regression test for the read/edit completion race. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
f302aba to
a8e1679
Compare
|
Result: Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Summary: Offline dependency installation and test compilation passed in the disposable container. Targeted inline-script suites reported **870 passing tests**, no failures, and five pending Windows-specific tests. Coverage included persistent Ready labels, live metadata edits, Undo, stale reads, setup validation, routing, and cache recovery. The eight new VS Code integration tests were not run because the sandbox lacks the required Electron/extension-host environment. Confidence is strong for unit-tested behavior, but end-to-end editor behavior remains unverified. Test runs: 6 passed, 1 not run
|
Rich Chiodo (rchiodo)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
e4f9939
into
microsoft:main
Summary
Script environment ready (Python X.Y.Z)persistent for validated, available script environments.Validation
npm run lintnpm run compile-testsnpm run unittest— 2,812 passing, 7 pending after rebasing onto the latestmainNotes
The tolerant block detector is presentation-only. Semantic parsing remains authoritative for diagnostics, setup eligibility, environment identity, persistence, and exact-file routing.
A separate full integration run completed with 57 passing and 8 pending tests plus one existing environment-creation timeout. The timed-out fixture selects the system manager, which cannot quick-create headlessly; instrumentation confirmed it does not enter the PEP 723 path.