Skip to content

Open native REPL in active group when no tabs are open - #26210

Open
Eduardo Villalpando Mello (edvilme) wants to merge 1 commit into
mainfrom
copilot/fix-native-repl-placement
Open

Eduardo Villalpando Mello (edvilme) wants to merge 1 commit into
mainfrom
copilot/fix-native-repl-placement

Conversation

@edvilme

Copy link
Copy Markdown

Summary

  • open a new native REPL in the active editor group when no tabs are open
  • preserve side-by-side placement when another tab is open and preserve the column of an existing REPL
  • add regression coverage for empty and non-empty editor layouts

Testing

  • npx tsc -p . --pretty false
  • npm run test:unittests -- --grep "REPL - command handler"
  • npx eslint src/client/repl/replCommandHandler.ts src/test/repl/replCommandHandler.unit.test.ts
  • npx prettier --check src/client/repl/replCommandHandler.ts src/test/repl/replCommandHandler.unit.test.ts

Fixes #24010

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@edvilme Eduardo Villalpando Mello (edvilme) added debt Code quality issues feature-request Request for new features or functionality and removed debt Code quality issues labels Oct 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused change matches the requested behavior, includes regression coverage, and has no identified blocking issues.

Review effort: Balanced
Findings: None

What changed in this PR

Addresses #24010 by opening a new native Python REPL in the active editor group when no tabs are open.

Changes:

  • Keeps side-by-side placement when tabs exist and preserves existing REPL placement.
  • Adds regression tests for empty and non-empty editor layouts.
File Description
src/​test/​repl/​replCommandHandler.unit.test.ts Tests placement with and without open tabs.
src/​client/​repl/​replCommandHandler.ts Selects new REPL placement based on open tabs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@bschnurr

Bill Schnurr (bschnurr) commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR.

@bschnurr

Copy link
Copy Markdown
Member

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "708a9bd41ab939071452c94526796f87ea6e406a6096b61c48396f6782ee3a00": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found

Test runs: none recorded.

@bschnurr Bill Schnurr (bschnurr) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@bschnurr Bill Schnurr (bschnurr) added the review-auto:approved Automated review: no blocking findings (approval posted). label Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request Request for new features or functionality review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start native repl always opens repl to side even if there is nothing open

3 participants