Repository navigation
Open native REPL in active group when no tabs are open - #26210
Eduardo Villalpando Mello (edvilme) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change matches the requested behavior, includes regression coverage, and has no identified blocking issues.
Review effort: Balanced
Findings: None
What changed in this PR
Addresses #24010 by opening a new native Python REPL in the active editor group when no tabs are open.
Changes:
- Keeps side-by-side placement when tabs exist and preserves existing REPL placement.
- Adds regression tests for empty and non-empty editor layouts.
| File | Description |
|---|---|
| src/test/repl/replCommandHandler.unit.test.ts | Tests placement with and without open tabs. |
| src/client/repl/replCommandHandler.ts | Selects new REPL placement based on open tabs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "708a9bd41ab939071452c94526796f87ea6e406a6096b61c48396f6782ee3a00": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found Test runs: none recorded. |
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Summary
Testing
npx tsc -p . --pretty falsenpm run test:unittests -- --grep "REPL - command handler"npx eslint src/client/repl/replCommandHandler.ts src/test/repl/replCommandHandler.unit.test.tsnpx prettier --check src/client/repl/replCommandHandler.ts src/test/repl/replCommandHandler.unit.test.tsFixes #24010