Fix object reference key collision in msgpack_var_add - #192
Open
LaurinKerkloh wants to merge 1 commit into
Open
LaurinKerkloh wants to merge 1 commit into
LaurinKerkloh wants to merge 1 commit into
Conversation
Objects were keyed by a mix of class entry pointer and handle, which is not unique: two objects of different classes could share a key, so one was packed as a back-reference to the other. Key objects by their zend_object address in a separate key space from arrays, and hold a reference to each packed object until packing ends so its address cannot be reused (as ext/standard/var.c does).
LaurinKerkloh
force-pushed
the
fix-var-hash-collision
branch
from
October 5, 2026 07:59
745e454 to
d8eba36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objects were keyed by a mix of class entry pointer and handle, which is not unique: two objects of different classes could share a key, so one was packed as a back-reference to the other.
Key objects by their zend_object address in a separate key space from arrays, and hold a reference to each packed object until packing ends so its address cannot be reused (as ext/standard/var.c does).
Fixes #191