Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash and encoding validators accept a final newline because the
$regular expression anchor can match immediately before it. For example,sha256("a" * 64 + "\n")currently returnsTrue, although the input contains a character outside the digest.Use
re.fullmatch()for the six digest validators and four encoding validators. This preserves the accepted alphabets, case handling, and padding rules while requiring the entire value to match. The regression tests cover trailing newlines, CRLF, spaces, and extra lines across all ten validators.Validation: the new tests produced 10 failures on unmodified
master; after the fix, all 935 tests pass. Ruff lint, formatting checks for the changed files, and the complete Pyright check pass with Python 3.14.6. No other interpreter versions were run locally.Developed, reviewed, and tested with AI assistance.