Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CUSIP and SEDOL validation accepts letters or symbols in the final check-digit position when their numeric expansion happens to satisfy the checksum. For example,
cusip("03783310J")andsedol("293692L")currently returnTrue.Require the last character to be an ASCII digit before calculating either checksum. Letters and permitted symbols remain accepted in the identifier body. Regression tests include the false positives and valid numeric-check-digit controls.
The final check digit is numeric in ANSI X9.6 §3.1 and LSEG's SEDOL technical specification §8.4–8.5.
Validation on Python 3.14.6: six regression cases fail on unmodified
master; all 904 tests pass after the fix. Complete Ruff lint and Pyright checks, plus changed-file formatting checks, pass. Other interpreter versions were not run locally.Developed, reviewed, and tested with AI assistance.