gh-154062: Stop normalizing differential flamegraph duration - #154082
Merged
pablogsal merged 4 commits intoOct 5, 2026
Merged
Conversation
This was referenced Jul 19, 2026
pablogsal
marked this pull request as ready for review
July 19, 2026 11:11
pablogsal
added
the
needs backport to 3.15
Member
Author
|
CC: @lkollar |
ivonastojanovic
approved these changes
Jul 21, 2026
ivonastojanovic
left a comment
ivonastojanovic
left a comment
Contributor
There was a problem hiding this comment.
Thanks @pablogsal!
pablogsal
force-pushed
the
agent/gh-154062-diff-flamegraph-duration
branch
from
August 25, 2026 23:52
4597816 to
a023541
Compare
pablogsal
removed
the
needs backport to 3.15
pablogsal
enabled auto-merge (squash)
October 5, 2026 15:52
|
GH-158871 is a backport of this pull request to the 3.15 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparing profiles with different total durations could make unchanged functions appear faster or slower. Convert baseline samples using the sample-interval ratio without normalizing the total duration. Elided frames use the same units for their geometry and differential metadata.
The regressions cover unchanged functions, different sampling intervals, nested elided frames, and an empty current profile.
Closes #154062.