Repository navigation
Conversation
Documentation build overview
5 files changed ·
|
vstinner
marked this pull request as ready for review
October 6, 2026 22:18
vstinner
requested review from
AA-Turner,
StanFromIreland,
encukou and
hugovk
as code owners
October 6, 2026 22:18
Member
Author
|
@encukou: Ok, here is a small PR only adding 7 macros. |
maurycy
reviewed
Oct 6, 2026
Member
|
Thanks for getting to this. I spent some time thinking about this but kept getting lost in rabbit-holes. Let's do this step first :) There's a few changes I'd like to make here. I sent them as vstinner#20. |
* distinguish between 'const' and 'macro' in stable_abi.dat The file now has the 'kind' from the toml, not the ReST role. * Fix kind of PY_VECTORCALL_ARGUMENTS_OFFSET * Regenerate stable_abi.dat * Make it explicit that macros aren't part of the ABI * Move is_static_inline_function (per-item data) to the TOML file * Appease linter rule, despite PEP 8
Member
Author
Thanks, I merged your PR.
If I can chose, I prefer that you create a PR on my branch, as you did. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc/stable_abi.toml#158886