Repository navigation
Fix self type check for generic NamedTuple with constrained typevar - #22119
Open
EmmanuelNiyonshuti wants to merge 2 commits into
Open
EmmanuelNiyonshuti wants to merge 2 commits into
EmmanuelNiyonshuti wants to merge 2 commits into
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: scipy-stubs (https://github.com/scipy/scipy-stubs)
+ tests/misc/test_submodules_empty.pyi:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21453
This PR makes it so that, for generic NamedTuples with a constrained typevar
and an unannotated self, the signature's self type with the substituted typevar
instance is used to substitute the ref_type(the class type seen from inside
the method), and they are the same type.
Otherwise the same-type check was failing, since ref_type would stay a typevar
type.