Repository navigation
Work around concurrent import bug on free-threaded Python - #22120
Merged
ilevkivskyi merged 1 commit intoOct 6, 2026
Merged
ilevkivskyi merged 1 commit into
ilevkivskyi merged 1 commit into
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI sometimes fails when accessing
mypy.nativeparseafter importing it. This appears to be caused by a race condition inimportlibwhere a child module can be initialized without being placed in its parent's__dict__. More details in this comment.Change the imports to
from mypy import nativeparseas a workaround. This way importlib falls back tosys.moduleswhen it can't find the child attribute in parent's__dict__.It also turns out that our command line tests in the wheel build CI launch interpreted mypy because
PYTHONPATHis set to the source directory but the wheel build does not place the compiled extensions there. ChangePYTHONPATHto the parent directory of themypypackage to use the compiled version when available.