Repository navigation
Retier react/renderer/uimanager headers (#58846) - #58846
Closed
j-piasecki wants to merge 1 commit into
Closed
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123391983. |
j-piasecki
force-pushed
the
export-D123391983
branch
from
October 5, 2026 09:48
a3ebeb6 to
3993c43
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 5, 2026
Summary: Pull Request resolved: react#58846 Make `AppRegistryBinding.h`, `LayoutEventEmitter.h` and the deprecated `SurfaceRegistryBinding.h` private; they are only used inside React Native. `UIManagerViewTransitionDelegate.h` now reaches `Float.h` through the `<React/Graphics.h>` umbrella instead of including it directly, since `Float.h` is public and its guard rejects direct includes from for-frameworks headers. Changelog: [Internal] Differential Revision: D123391983
j-piasecki
force-pushed
the
export-D123391983
branch
from
October 5, 2026 09:52
3993c43 to
c776258
Compare
meta-codesync
Bot
changed the title
react/renderer/uimanager headersreact/renderer/uimanager headers (#58846)
j-piasecki
force-pushed
the
export-D123391983
branch
from
October 5, 2026 10:46
c776258 to
b341f47
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 5, 2026
Summary: Make `AppRegistryBinding.h`, `LayoutEventEmitter.h` and the deprecated `SurfaceRegistryBinding.h` private; they are only used inside React Native. `UIManagerViewTransitionDelegate.h` now reaches `Float.h` through the `<React/Graphics.h>` umbrella instead of including it directly, since `Float.h` is public and its guard rejects direct includes from for-frameworks headers. Changelog: [Internal] Differential Revision: D123391983
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 5, 2026
Summary: Make `AppRegistryBinding.h`, `LayoutEventEmitter.h` and the deprecated `SurfaceRegistryBinding.h` private; they are only used inside React Native. `UIManagerViewTransitionDelegate.h` now reaches `Float.h` through the `<React/Graphics.h>` umbrella instead of including it directly, since `Float.h` is public and its guard rejects direct includes from for-frameworks headers. Changelog: [Internal] Differential Revision: D123391983
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 5, 2026
Summary: Make `AppRegistryBinding.h`, `LayoutEventEmitter.h` and the deprecated `SurfaceRegistryBinding.h` private; they are only used inside React Native. `UIManagerViewTransitionDelegate.h` now reaches `Float.h` through the `<React/Graphics.h>` umbrella instead of including it directly, since `Float.h` is public and its guard rejects direct includes from for-frameworks headers. Changelog: [Internal] Differential Revision: D123391983
j-piasecki
force-pushed
the
export-D123391983
branch
from
October 5, 2026 11:20
b341f47 to
a50984b
Compare
Summary: Make `AppRegistryBinding.h`, `LayoutEventEmitter.h` and the deprecated `SurfaceRegistryBinding.h` private; they are only used inside React Native. `UIManagerViewTransitionDelegate.h` now reaches `Float.h` through the `<React/Graphics.h>` umbrella instead of including it directly, since `Float.h` is public and its guard rejects direct includes from for-frameworks headers. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D123391983
j-piasecki
force-pushed
the
export-D123391983
branch
from
October 9, 2026 08:03
a50984b to
948a0e0
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 9, 2026
Summary: Make `AppRegistryBinding.h`, `LayoutEventEmitter.h` and the deprecated `SurfaceRegistryBinding.h` private; they are only used inside React Native. `UIManagerViewTransitionDelegate.h` now reaches `Float.h` through the `<React/Graphics.h>` umbrella instead of including it directly, since `Float.h` is public and its guard rejects direct includes from for-frameworks headers. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D123391983
|
This pull request has been merged in 79db08c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Make
AppRegistryBinding.h,LayoutEventEmitter.hand the deprecatedSurfaceRegistryBinding.hprivate; they are only used inside React Native.UIManagerViewTransitionDelegate.hnow reachesFloat.hthrough the<React/Graphics.h>umbrella instead of including it directly, sinceFloat.his public and its guard rejects direct includes from for-frameworks headers.Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D123391983