Fix reversed wheel/joystick scrolling in inverted lists - #58872
Open
pixelfreak wants to merge 1 commit into
Open
pixelfreak wants to merge 1 commit into
pixelfreak wants to merge 1 commit into
Conversation
Summary: - On Android, an inverted `FlatList` flips its `ScrollView` with a transform. Android maps touch coordinates through that transform, but `ACTION_SCROLL` axis values (mouse wheel, trackpad, joystick) reach the view unchanged, so those inputs scroll inverted lists backwards. - `ReactScrollView.onGenericMotionEvent` now negates the vertical scroll axis when transforms on the view or its ancestors flip it vertically, and the snap velocity after a wheel scroll is flipped to match. Children of the list still receive the original event. - Checking the transforms rather than `isInvertedVirtualizedList` also covers other flipped `ScrollView`s, including an inverted list with a `refreshControl`, where the transform sits on the wrapping refresh layout. - `ReactNestedScrollView` is regenerated from the `ReactScrollView` sources. Changelog: [Android][Fixed] - Fix mouse wheel and joystick scrolling direction in inverted `FlatList` Reviewed By: GijsWeterings, javache Differential Revision: D122871988
meta-cla
Bot
added
the
CLA Signed
|
@pixelfreak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122871988. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
FlatListflips itsScrollViewwith a transform. Android maps touch coordinates through that transform, butACTION_SCROLLaxis values (mouse wheel, trackpad, joystick) reach the view unchanged, so those inputs scroll inverted lists backwards.ReactScrollView.onGenericMotionEventnow negates the vertical scroll axis when transforms on the view or its ancestors flip it vertically, and the snap velocity after a wheel scroll is flipped to match. Children of the list still receive the original event.isInvertedVirtualizedListalso covers other flippedScrollViews, including an inverted list with arefreshControl, where the transform sits on the wrapping refresh layout.ReactNestedScrollViewis regenerated from theReactScrollViewsources.Changelog:
[Android][Fixed] - Fix mouse wheel and joystick scrolling direction in inverted
FlatListReviewed By: GijsWeterings, javache
Differential Revision: D122871988