Skip to content

Make core Dynamic* and ReactRootViewTagGenerator headers for-frameworks (#58884) #58884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-piasecki wants to merge 1 commit into from
Closed

Make core Dynamic* and ReactRootViewTagGenerator headers for-frameworks (#58884) #58884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/core/DynamicEventPayload.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/UmbrellaGuard.h>
#include <react/cxxstableapi/FrameworksGuard.h>

#include <folly/dynamic.h>
#include <react/renderer/core/EventPayload.h>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/core/DynamicPointerEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/UmbrellaGuard.h>
#include <react/cxxstableapi/FrameworksGuard.h>

#include <folly/dynamic.h>
#include <react/renderer/core/DynamicEventPayload.h>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/core/DynamicPropsUtilities.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/UmbrellaGuard.h>
#include <react/cxxstableapi/FrameworksGuard.h>

#include <folly/dynamic.h>
#include <react/renderer/core/RawProps.h>
Expand Down
4 changes: 0 additions & 4 deletions packages/react-native/ReactCommon/react/renderer/core/React/RendererCore.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@
#include <react/renderer/core/ConcreteComponentDescriptor.h>
#include <react/renderer/core/ConcreteShadowNode.h>
#include <react/renderer/core/ConcreteState.h>
#include <react/renderer/core/DynamicEventPayload.h>
#include <react/renderer/core/DynamicPointerEvent.h>
#include <react/renderer/core/DynamicPropsUtilities.h>
#include <react/renderer/core/EventBeat.h>
#include <react/renderer/core/EventDispatcher.h>
#include <react/renderer/core/EventEmitter.h>
Expand All @@ -67,7 +64,6 @@
#include <react/renderer/core/RawPropsParser.h>
#include <react/renderer/core/ReactEventPriority.h>
#include <react/renderer/core/ReactPrimitives.h>
#include <react/renderer/core/ReactRootViewTagGenerator.h>
#include <react/renderer/core/Sealable.h>
#include <react/renderer/core/ShadowNode.h>
#include <react/renderer/core/ShadowNodeFamily.h>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/core/ReactRootViewTagGenerator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/UmbrellaGuard.h>
#include <react/cxxstableapi/FrameworksGuard.h>

#include <react/renderer/core/ReactPrimitives.h>

Expand Down
22 changes: 0 additions & 22 deletions scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,6 @@ facebook::react::SharedColor facebook::react::colorFromRGBA(uint8_t r, uint8_t g
facebook::react::SharedColor facebook::react::parsePlatformColor(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value);
facebook::react::SharedColor facebook::react::whiteColor();
facebook::react::Size facebook::react::yogaMeassureToSize(int64_t value);
facebook::react::SurfaceId facebook::react::getNextRootViewTag() noexcept;
facebook::react::TurboModuleMethodValueKind facebook::react::getTurboModuleMethodValueKind(facebook::jsi::Runtime& rt, const facebook::jsi::Value* value);
facebook::react::ValueUnit facebook::react::toValueUnit(const facebook::react::RawValue& value);
facebook::yoga::FloatOptional facebook::react::convertAspectRatio(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value);
Expand All @@ -530,8 +529,6 @@ float facebook::react::blueFromHostPlatformColor(facebook::react::Color color);
float facebook::react::greenFromHostPlatformColor(facebook::react::Color color);
float facebook::react::redFromHostPlatformColor(facebook::react::Color color);
float facebook::react::yogaFloatFromFloat(facebook::react::Float value);
folly::dynamic facebook::react::diffDynamicProps(const folly::dynamic& oldProps, const folly::dynamic& newProps);
folly::dynamic facebook::react::mergeDynamicProps(const folly::dynamic& source, const folly::dynamic& patch, facebook::react::NullValueStrategy nullValueStrategy);
folly::dynamic facebook::react::toDynamic(const YGValue& dimension);
folly::dynamic facebook::react::toDynamic(const facebook::react::BackgroundImage& backgroundImage);
folly::dynamic facebook::react::toDynamic(const facebook::react::BoxShadow& boxShadow);
Expand Down Expand Up @@ -2927,11 +2924,6 @@ enum facebook::react::ModalHostViewSupportedOrientations : facebook::react::Moda
PortraitUpsideDown,
}

enum facebook::react::NullValueStrategy {
Ignore,
Override,
}

enum facebook::react::OutlineStyle : uint8_t {
Dashed,
Dotted,
Expand Down Expand Up @@ -3289,20 +3281,6 @@ struct facebook::react::DropShadowParams {
public folly::dynamic toDynamic() const;
}

struct facebook::react::DynamicEventPayload : public facebook::react::EventPayload {
protected folly::dynamic payload_;
public DynamicEventPayload(folly::dynamic&& payload);
public static facebook::react::SharedEventPayload create(folly::dynamic&& payload);
public virtual facebook::jsi::Value asJSIValue(facebook::jsi::Runtime& runtime) const override;
public virtual facebook::react::EventPayloadType getType() const override;
public virtual std::optional<double> extractValue(const std::vector<std::string>&) const override;
}

struct facebook::react::DynamicPointerEvent : public facebook::react::DynamicEventPayload {
public DynamicPointerEvent(folly::dynamic&& payload);
public const std::optional<std::vector<facebook::react::Tag>>& getHitPathForEventListener() const;
}

struct facebook::react::EventPayload {
public EventPayload() = default;
public EventPayload(const facebook::react::EventPayload&) = default;
Expand Down
22 changes: 0 additions & 22 deletions scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,6 @@ facebook::react::SharedColor facebook::react::colorFromRGBA(uint8_t r, uint8_t g
facebook::react::SharedColor facebook::react::parsePlatformColor(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value);
facebook::react::SharedColor facebook::react::whiteColor();
facebook::react::Size facebook::react::yogaMeassureToSize(int64_t value);
facebook::react::SurfaceId facebook::react::getNextRootViewTag() noexcept;
facebook::react::TurboModuleMethodValueKind facebook::react::getTurboModuleMethodValueKind(facebook::jsi::Runtime& rt, const facebook::jsi::Value* value);
facebook::react::ValueUnit facebook::react::toValueUnit(const facebook::react::RawValue& value);
facebook::yoga::FloatOptional facebook::react::convertAspectRatio(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value);
Expand All @@ -530,8 +529,6 @@ float facebook::react::blueFromHostPlatformColor(facebook::react::Color color);
float facebook::react::greenFromHostPlatformColor(facebook::react::Color color);
float facebook::react::redFromHostPlatformColor(facebook::react::Color color);
float facebook::react::yogaFloatFromFloat(facebook::react::Float value);
folly::dynamic facebook::react::diffDynamicProps(const folly::dynamic& oldProps, const folly::dynamic& newProps);
folly::dynamic facebook::react::mergeDynamicProps(const folly::dynamic& source, const folly::dynamic& patch, facebook::react::NullValueStrategy nullValueStrategy);
folly::dynamic facebook::react::toDynamic(const YGValue& dimension);
folly::dynamic facebook::react::toDynamic(const facebook::react::BackgroundImage& backgroundImage);
folly::dynamic facebook::react::toDynamic(const facebook::react::BoxShadow& boxShadow);
Expand Down Expand Up @@ -2920,11 +2917,6 @@ enum facebook::react::ModalHostViewSupportedOrientations : facebook::react::Moda
PortraitUpsideDown,
}

enum facebook::react::NullValueStrategy {
Ignore,
Override,
}

enum facebook::react::OutlineStyle : uint8_t {
Dashed,
Dotted,
Expand Down Expand Up @@ -3282,20 +3274,6 @@ struct facebook::react::DropShadowParams {
public folly::dynamic toDynamic() const;
}

struct facebook::react::DynamicEventPayload : public facebook::react::EventPayload {
protected folly::dynamic payload_;
public DynamicEventPayload(folly::dynamic&& payload);
public static facebook::react::SharedEventPayload create(folly::dynamic&& payload);
public virtual facebook::jsi::Value asJSIValue(facebook::jsi::Runtime& runtime) const override;
public virtual facebook::react::EventPayloadType getType() const override;
public virtual std::optional<double> extractValue(const std::vector<std::string>&) const override;
}

struct facebook::react::DynamicPointerEvent : public facebook::react::DynamicEventPayload {
public DynamicPointerEvent(folly::dynamic&& payload);
public const std::optional<std::vector<facebook::react::Tag>>& getHitPathForEventListener() const;
}

struct facebook::react::EventPayload {
public EventPayload() = default;
public EventPayload(const facebook::react::EventPayload&) = default;
Expand Down
22 changes: 0 additions & 22 deletions scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,6 @@ facebook::react::SharedColor facebook::react::colorFromRGBA(uint8_t r, uint8_t g
facebook::react::SharedColor facebook::react::parsePlatformColor(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value);
facebook::react::SharedColor facebook::react::whiteColor();
facebook::react::Size facebook::react::yogaMeassureToSize(int64_t value);
facebook::react::SurfaceId facebook::react::getNextRootViewTag() noexcept;
facebook::react::TurboModuleMethodValueKind facebook::react::getTurboModuleMethodValueKind(facebook::jsi::Runtime& rt, const facebook::jsi::Value* value);
facebook::react::ValueUnit facebook::react::toValueUnit(const facebook::react::RawValue& value);
facebook::yoga::FloatOptional facebook::react::convertAspectRatio(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value);
Expand All @@ -530,8 +529,6 @@ float facebook::react::blueFromHostPlatformColor(facebook::react::Color color);
float facebook::react::greenFromHostPlatformColor(facebook::react::Color color);
float facebook::react::redFromHostPlatformColor(facebook::react::Color color);
float facebook::react::yogaFloatFromFloat(facebook::react::Float value);
folly::dynamic facebook::react::diffDynamicProps(const folly::dynamic& oldProps, const folly::dynamic& newProps);
folly::dynamic facebook::react::mergeDynamicProps(const folly::dynamic& source, const folly::dynamic& patch, facebook::react::NullValueStrategy nullValueStrategy);
folly::dynamic facebook::react::toDynamic(const YGValue& dimension);
folly::dynamic facebook::react::toDynamic(const facebook::react::BackgroundImage& backgroundImage);
folly::dynamic facebook::react::toDynamic(const facebook::react::BoxShadow& boxShadow);
Expand Down Expand Up @@ -2920,11 +2917,6 @@ enum facebook::react::ModalHostViewSupportedOrientations : facebook::react::Moda
PortraitUpsideDown,
}

enum facebook::react::NullValueStrategy {
Ignore,
Override,
}

enum facebook::react::OutlineStyle : uint8_t {
Dashed,
Dotted,
Expand Down Expand Up @@ -3282,20 +3274,6 @@ struct facebook::react::DropShadowParams {
public folly::dynamic toDynamic() const;
}

struct facebook::react::DynamicEventPayload : public facebook::react::EventPayload {
protected folly::dynamic payload_;
public DynamicEventPayload(folly::dynamic&& payload);
public static facebook::react::SharedEventPayload create(folly::dynamic&& payload);
public virtual facebook::jsi::Value asJSIValue(facebook::jsi::Runtime& runtime) const override;
public virtual facebook::react::EventPayloadType getType() const override;
public virtual std::optional<double> extractValue(const std::vector<std::string>&) const override;
}

struct facebook::react::DynamicPointerEvent : public facebook::react::DynamicEventPayload {
public DynamicPointerEvent(folly::dynamic&& payload);
public const std::optional<std::vector<facebook::react::Tag>>& getHitPathForEventListener() const;
}

struct facebook::react::EventPayload {
public EventPayload() = default;
public EventPayload(const facebook::react::EventPayload&) = default;
Expand Down
22 changes: 0 additions & 22 deletions scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3311,7 +3311,6 @@ facebook::react::SharedColor facebook::react::colorFromRGBA(uint8_t r, uint8_t g
facebook::react::SharedColor facebook::react::parsePlatformColor(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value);
facebook::react::SharedColor facebook::react::whiteColor();
facebook::react::Size facebook::react::yogaMeassureToSize(int64_t value);
facebook::react::SurfaceId facebook::react::getNextRootViewTag() noexcept;
facebook::react::TurboModuleMethodValueKind facebook::react::getTurboModuleMethodValueKind(facebook::jsi::Runtime& rt, const facebook::jsi::Value* value);
facebook::react::ValueUnit facebook::react::toValueUnit(const facebook::react::RawValue& value);
facebook::yoga::FloatOptional facebook::react::convertAspectRatio(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value);
Expand All @@ -3322,8 +3321,6 @@ float facebook::react::greenFromHostPlatformColor(facebook::react::Color color);
float facebook::react::redFromHostPlatformColor(facebook::react::Color color);
float facebook::react::yogaFloatFromFloat(facebook::react::Float value);
folly::dynamic facebook::react::convertIdToFollyDynamic(id json);
folly::dynamic facebook::react::diffDynamicProps(const folly::dynamic& oldProps, const folly::dynamic& newProps);
folly::dynamic facebook::react::mergeDynamicProps(const folly::dynamic& source, const folly::dynamic& patch, facebook::react::NullValueStrategy nullValueStrategy);
id facebook::react::convertFollyDynamicToId(const folly::dynamic& dyn);
int facebook::react::toInt(const facebook::react::DisplayType& displayType);
int facebook::react::toInt(const facebook::react::LayoutDirection& layoutDirection);
Expand Down Expand Up @@ -5125,11 +5122,6 @@ enum facebook::react::ModalHostViewSupportedOrientations : facebook::react::Moda
PortraitUpsideDown,
}

enum facebook::react::NullValueStrategy {
Ignore,
Override,
}

enum facebook::react::OutlineStyle : uint8_t {
Dashed,
Dotted,
Expand Down Expand Up @@ -5461,20 +5453,6 @@ struct facebook::react::DynamicColor {
public int32_t lightColor;
}

struct facebook::react::DynamicEventPayload : public facebook::react::EventPayload {
protected folly::dynamic payload_;
public DynamicEventPayload(folly::dynamic&& payload);
public static facebook::react::SharedEventPayload create(folly::dynamic&& payload);
public virtual facebook::jsi::Value asJSIValue(facebook::jsi::Runtime& runtime) const override;
public virtual facebook::react::EventPayloadType getType() const override;
public virtual std::optional<double> extractValue(const std::vector<std::string>& path) const override;
}

struct facebook::react::DynamicPointerEvent : public facebook::react::DynamicEventPayload {
public DynamicPointerEvent(folly::dynamic&& payload);
public const std::optional<std::vector<facebook::react::Tag>>& getHitPathForEventListener() const;
}

struct facebook::react::EventPayload {
public EventPayload() = default;
public EventPayload(const facebook::react::EventPayload&) = default;
Expand Down
22 changes: 0 additions & 22 deletions scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3303,7 +3303,6 @@ facebook::react::SharedColor facebook::react::colorFromRGBA(uint8_t r, uint8_t g
facebook::react::SharedColor facebook::react::parsePlatformColor(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value);
facebook::react::SharedColor facebook::react::whiteColor();
facebook::react::Size facebook::react::yogaMeassureToSize(int64_t value);
facebook::react::SurfaceId facebook::react::getNextRootViewTag() noexcept;
facebook::react::TurboModuleMethodValueKind facebook::react::getTurboModuleMethodValueKind(facebook::jsi::Runtime& rt, const facebook::jsi::Value* value);
facebook::react::ValueUnit facebook::react::toValueUnit(const facebook::react::RawValue& value);
facebook::yoga::FloatOptional facebook::react::convertAspectRatio(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value);
Expand All @@ -3314,8 +3313,6 @@ float facebook::react::greenFromHostPlatformColor(facebook::react::Color color);
float facebook::react::redFromHostPlatformColor(facebook::react::Color color);
float facebook::react::yogaFloatFromFloat(facebook::react::Float value);
folly::dynamic facebook::react::convertIdToFollyDynamic(id json);
folly::dynamic facebook::react::diffDynamicProps(const folly::dynamic& oldProps, const folly::dynamic& newProps);
folly::dynamic facebook::react::mergeDynamicProps(const folly::dynamic& source, const folly::dynamic& patch, facebook::react::NullValueStrategy nullValueStrategy);
id facebook::react::convertFollyDynamicToId(const folly::dynamic& dyn);
int facebook::react::toInt(const facebook::react::DisplayType& displayType);
int facebook::react::toInt(const facebook::react::LayoutDirection& layoutDirection);
Expand Down Expand Up @@ -5110,11 +5107,6 @@ enum facebook::react::ModalHostViewSupportedOrientations : facebook::react::Moda
PortraitUpsideDown,
}

enum facebook::react::NullValueStrategy {
Ignore,
Override,
}

enum facebook::react::OutlineStyle : uint8_t {
Dashed,
Dotted,
Expand Down Expand Up @@ -5446,20 +5438,6 @@ struct facebook::react::DynamicColor {
public int32_t lightColor;
}

struct facebook::react::DynamicEventPayload : public facebook::react::EventPayload {
protected folly::dynamic payload_;
public DynamicEventPayload(folly::dynamic&& payload);
public static facebook::react::SharedEventPayload create(folly::dynamic&& payload);
public virtual facebook::jsi::Value asJSIValue(facebook::jsi::Runtime& runtime) const override;
public virtual facebook::react::EventPayloadType getType() const override;
public virtual std::optional<double> extractValue(const std::vector<std::string>& path) const override;
}

struct facebook::react::DynamicPointerEvent : public facebook::react::DynamicEventPayload {
public DynamicPointerEvent(folly::dynamic&& payload);
public const std::optional<std::vector<facebook::react::Tag>>& getHitPathForEventListener() const;
}

struct facebook::react::EventPayload {
public EventPayload() = default;
public EventPayload(const facebook::react::EventPayload&) = default;
Expand Down
22 changes: 0 additions & 22 deletions scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3311,7 +3311,6 @@ facebook::react::SharedColor facebook::react::colorFromRGBA(uint8_t r, uint8_t g
facebook::react::SharedColor facebook::react::parsePlatformColor(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value);
facebook::react::SharedColor facebook::react::whiteColor();
facebook::react::Size facebook::react::yogaMeassureToSize(int64_t value);
facebook::react::SurfaceId facebook::react::getNextRootViewTag() noexcept;
facebook::react::TurboModuleMethodValueKind facebook::react::getTurboModuleMethodValueKind(facebook::jsi::Runtime& rt, const facebook::jsi::Value* value);
facebook::react::ValueUnit facebook::react::toValueUnit(const facebook::react::RawValue& value);
facebook::yoga::FloatOptional facebook::react::convertAspectRatio(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value);
Expand All @@ -3322,8 +3321,6 @@ float facebook::react::greenFromHostPlatformColor(facebook::react::Color color);
float facebook::react::redFromHostPlatformColor(facebook::react::Color color);
float facebook::react::yogaFloatFromFloat(facebook::react::Float value);
folly::dynamic facebook::react::convertIdToFollyDynamic(id json);
folly::dynamic facebook::react::diffDynamicProps(const folly::dynamic& oldProps, const folly::dynamic& newProps);
folly::dynamic facebook::react::mergeDynamicProps(const folly::dynamic& source, const folly::dynamic& patch, facebook::react::NullValueStrategy nullValueStrategy);
id facebook::react::convertFollyDynamicToId(const folly::dynamic& dyn);
int facebook::react::toInt(const facebook::react::DisplayType& displayType);
int facebook::react::toInt(const facebook::react::LayoutDirection& layoutDirection);
Expand Down Expand Up @@ -5118,11 +5115,6 @@ enum facebook::react::ModalHostViewSupportedOrientations : facebook::react::Moda
PortraitUpsideDown,
}

enum facebook::react::NullValueStrategy {
Ignore,
Override,
}

enum facebook::react::OutlineStyle : uint8_t {
Dashed,
Dotted,
Expand Down Expand Up @@ -5454,20 +5446,6 @@ struct facebook::react::DynamicColor {
public int32_t lightColor;
}

struct facebook::react::DynamicEventPayload : public facebook::react::EventPayload {
protected folly::dynamic payload_;
public DynamicEventPayload(folly::dynamic&& payload);
public static facebook::react::SharedEventPayload create(folly::dynamic&& payload);
public virtual facebook::jsi::Value asJSIValue(facebook::jsi::Runtime& runtime) const override;
public virtual facebook::react::EventPayloadType getType() const override;
public virtual std::optional<double> extractValue(const std::vector<std::string>& path) const override;
}

struct facebook::react::DynamicPointerEvent : public facebook::react::DynamicEventPayload {
public DynamicPointerEvent(folly::dynamic&& payload);
public const std::optional<std::vector<facebook::react::Tag>>& getHitPathForEventListener() const;
}

struct facebook::react::EventPayload {
public EventPayload() = default;
public EventPayload(const facebook::react::EventPayload&) = default;
Expand Down
Loading
Loading