Repository navigation
Store an application's location directly in Lambda.lambda_apply - #8736
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## remove-inlined-attribute #8736 +/- ##
============================================================
- Coverage 79.87% 79.87% -0.01%
============================================================
Files 464 464
Lines 63079 63078 -1
============================================================
- Hits 50383 50382 -1
Misses 12696 12696
🚀 New features to boost your workflow:
|
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
7d7b005 to
b93f54e
Compare
Removing the @inlined attribute left ap_info as a record with a single field, ap_loc. Store the location in lambda_apply instead, and pass it to Lambda.apply as a plain Location.t, like prim takes its location. Signed-off-by: Christoph Knittel <christoph@knittel.cc> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
b93f54e to
306d389
Compare
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Follow-up to #8734, stacked on it.
Removing the
@inlinedattribute leftLambda.ap_infoas a record with a single field,ap_loc. This stores the location directly inlambda_apply(ap_loc: Location.t) and passes it toLambda.applyas a plainLocation.t, the same wayprimtakes its location.It's a mechanical refactor of 12 files in
compiler/mlandcompiler/core, with no change in behavior or generated JavaScript..cmjfiles store Lambda terms, so their layout changes; they're rebuilt with the compiler anyway.🤖 Generated with Claude Code