Repository navigation
Don't let RUBY_YJIT_ENABLE turn the interp executable into YJIT - #542
Merged
Merged
Conversation
With RUBY_YJIT_ENABLE=1 in the environment, the default "interp" executable silently ran with YJIT and the comparison measured YJIT against itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a JIT is enabled with
RUBY_YJIT_ENABLEorRUBY_ZJIT_ENABLE,run_benchmarks.rbcannot run the benchmarks correctly. Theinterpexecutable also runs with the JIT, so the results compare the JIT against itself.This PR removes both variables before running the executables, so only each executable's own flags decide whether a JIT is enabled.
Generated with Claude Code