Repository navigation
Add cooperative cancellation and refine scheduler capabilities. - #17
Open
samuel-williams-shopify wants to merge 2 commits into
Open
samuel-williams-shopify wants to merge 2 commits into
samuel-williams-shopify wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add runtime-independent
Cancellation,Cancelled, anddefer_cancelso futures can respond to shutdown requests and continue asynchronous cleanup. Rename the portable scheduler capabilities fromFileIotoFileand fromNetworktoSocketacross the facade, native selectors, and Tokio adapter.Cancellation clones share persistent state, child signals receive ancestor cancellation, and dropping a signal does not request shutdown.
defer_cancelinvokes a synchronous callback once and continues polling the protected future. Tests cover registration races, wakeups, ancestor lifetimes, deep trees, callback timing, pinning, and cleanup on Socketry and Tokio. Existing task and scheduler destruction semantics remain in place; cooperative runtime draining and cancellation-aware I/O are future work.The executor design records the proposed scheduler interface, capability boundaries, prepared linking, owned and registered buffers, and pool receives, with examples for file reads, forwarding, synchronization, and service shutdown.
with_previous_bufferremains hypothetical with no selected implementation target. Update examples, package documentation, release notes, and the architectural gaps alongside these changes.