Skip to content

chore(1.x): publish under the v1-latest dist-tag - #2336

Merged
ryansolid merged 1 commit into
1.xfrom
chore/1.x-dist-tag-v1-latest
Oct 7, 2026
Merged

ryansolid merged 1 commit into
1.xfrom
chore/1.x-dist-tag-v1-latest

Conversation

@ryansolid

Copy link
Copy Markdown
Member

Summary

The 1.3.5 publish in Release run 37690794659 (from merging #2335) failed before anything was uploaded, because npm refuses v1 as a dist-tag:

🦋  error npm error Tag name must not be a valid SemVer range: v1
🦋  error packages failed to publish:
🦋  @solidjs/start@1.3.5

npm rejects any dist-tag name that also parses as a version range, and v1 is the range >=1.0.0 <2.0.0-0. #2333 introduced --tag v1; this changes the release script to changeset publish --tag v1-latest, which is not a range (semver.validRange("v1-latest") returns null).

Nothing was published, tagged, or released by the failed run: @solidjs/start@1.3.5 is not on npm, latest is still 2.0.6, and there is no @solidjs/start@1.3.5 git tag or GitHub release.

Merging this re-runs the pending 1.3.5 publish. 1.x is already at 1.3.5 with no pending changesets, so the Release workflow goes straight to changeset publish on this push. 1.x versions then install with npm i @solidjs/start@v1-latest.

Behavior changes

  • pnpm release runs changeset publish --tag v1-latest instead of --tag v1. latest stays on 2.x.

Public API changes

None. Release-script change only; no package source is touched, so there is no changeset.

Testing

  • semver.validRange("v1-latest") is null; semver.validRange("v1") is >=1.0.0 <2.0.0-0, matching npm's rejection.
  • The same run confirmed the parts of the chore(1.x): publish via npm trusted publishing under the v1 dist-tag #2333 workflow that come before the upload: changesets/action logged No NPM_TOKEN found, but OIDC is available - using npm trusted publishing, and pnpm 10 handed the publish to npm. The OIDC upload itself runs for the first time when this merges.

Prepared with Claude via Cursor

Co-Authored-By: Claude <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Oct 7, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9e5ca4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Oct 7, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@2336

commit: 9e5ca4c

@ryansolid
ryansolid merged commit f4d42c6 into 1.x Oct 7, 2026
7 checks passed
@ryansolid
ryansolid deleted the chore/1.x-dist-tag-v1-latest branch October 7, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant