Repository navigation
chore(1.x): publish under the v1-latest dist-tag - #2336
Merged
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
|
3 tasks
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 1.3.5 publish in Release run 37690794659 (from merging #2335) failed before anything was uploaded, because npm refuses
v1as a dist-tag:npm rejects any dist-tag name that also parses as a version range, and
v1is the range>=1.0.0 <2.0.0-0. #2333 introduced--tag v1; this changes the release script tochangeset publish --tag v1-latest, which is not a range (semver.validRange("v1-latest")returnsnull).Nothing was published, tagged, or released by the failed run:
@solidjs/start@1.3.5is not on npm,latestis still 2.0.6, and there is no@solidjs/start@1.3.5git tag or GitHub release.Merging this re-runs the pending 1.3.5 publish.
1.xis already at 1.3.5 with no pending changesets, so the Release workflow goes straight tochangeset publishon this push. 1.x versions then install withnpm i @solidjs/start@v1-latest.Behavior changes
pnpm releaserunschangeset publish --tag v1-latestinstead of--tag v1.lateststays on 2.x.Public API changes
None. Release-script change only; no package source is touched, so there is no changeset.
Testing
semver.validRange("v1-latest")isnull;semver.validRange("v1")is>=1.0.0 <2.0.0-0, matching npm's rejection.No NPM_TOKEN found, but OIDC is available - using npm trusted publishing, and pnpm 10 handed the publish to npm. The OIDC upload itself runs for the first time when this merges.Prepared with Claude via Cursor