Repository navigation
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughAdds a shared Kafka test that commits a record in a transaction and checks that a ChangesKafka Transaction Test Coverage
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change only adds tests for Kafka transactions on both container types and does not change production behavior. No merge-blocking risk was found. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Kafka transactions need
transaction.state.log.replication.factorandtransaction.state.log.min.isrset to 1 on a single broker. Without them,initTransactions()times out while waiting forInitProducerId.KafkaContainerandConfluentKafkaContaineralready set these values, but no test checks it. This PR adds a test for each class. The test commits a transaction and reads the message with aread_committedconsumer.Refs #1816
Summary by CodeRabbit