Repository navigation
Conversation
|
|
Hi @shayomi, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| type: fix | ||
| --- | ||
|
|
||
| Return a not-found response when a missing transcript receives an object-store 404 without a reason phrase |
There was a problem hiding this comment.
The response intentionally has an empty reason phrase. The test calls
ObjectStoreClient.getObjectResponse()and verifies that the resulting error is recognized byisTranscriptNotFound().Static verification completed:
Before marking this PR ready for review, run:
Changelog
Missing transcript downloads now return a not-found response when the object store responds with HTTP 404 without a reason phrase.
Implementation
The aws4fetch object-store adapter previously created download errors using only
response.statusText. Since HTTP reason phrases are optional, a valid 404 response could produce an error message with no"Not Found"text.The adapter now preserves the numeric HTTP status on the error. Transcript error classification checks that status first while retaining the existing AWS SDK and message-based fallbacks.
A
.server-changes/entry is included because this is a user-visible webapp bug fix.Screenshots
Not applicable. This change affects transcript-download error handling and has no visual UI changes.