Skip to content

feat(stovepipe): persist List summary fields - storage/materializer updates - #777

Merged
mnoah1 merged 1 commit into
mainfrom
mnoah1/stovepipe-list-summary
Oct 6, 2026
Merged

mnoah1 merged 1 commit into
mainfrom
mnoah1/stovepipe-list-summary

Conversation

@mnoah1

@mnoah1 mnoah1 commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Intent:

  • Persist additional fields: acceptance timestamp, and outcome reason, in the projected request summaries
  • Some refactoring in the summary projection logic to more clearly split out projection of facts from specific log events, from projection of state changes

Changes:

  • Persist acceptance time (0 when unknown) and the existing typed outcome reason.
  • Repair missing fields on replay without regressing newer state; retain CAS retries and idempotency.
  • Append the SQL columns and extend behavioral/storage tests.

Test Plan

Issues

@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-list-summary branch from 5a6029d to 9c76dc7 Compare October 5, 2026 20:32
@mnoah1
mnoah1 changed the base branch from mnoah1/stovepipe-list-api-rfc to main October 5, 2026 20:32
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-list-summary branch 2 times, most recently from 34e22a1 to 2d53af0 Compare October 6, 2026 14:52
Comment thread stovepipe/extension/storage/mysql/schema/request_summary.sql
@mnoah1 mnoah1 changed the title feat(stovepipe): persist List summary fields feat(stovepipe): persist List summary fields - storage/materializer updates Oct 6, 2026
@mnoah1
mnoah1 marked this pull request as ready for review October 6, 2026 15:01
@mnoah1
mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners October 6, 2026 15:01
@mnoah1
mnoah1 enabled auto-merge October 6, 2026 15:02
@mnoah1
mnoah1 disabled the stack merge October 6, 2026 15:38
@mnoah1
mnoah1 added this pull request to stack #783 October 6, 2026 15:38
Summary:
Intent:
- Prepare existing request summaries for the approved List contract.
- This is a standalone summary change; the List endpoint remains pending.

Changes:
- Persist acceptance time (0 when unknown) and the existing typed outcome reason.
- Repair missing fields on replay without regressing newer state; retain CAS retries and idempotency.
- Append the SQL columns and extend behavioral/storage tests.

Deployment:
- Additive migration is covered internally through UQL and must precede the new binary; no migration files are included here.

---

<sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-list-summary branch from 0e69a56 to b50531a Compare October 6, 2026 17:53
@mnoah1
mnoah1 added this pull request to the merge queue Oct 6, 2026
Merged via the queue into main with commit 18c10eb Oct 6, 2026
16 checks passed
@mnoah1
mnoah1 deployed to stack-rebase October 6, 2026 18:02 — with GitHub Actions Active
@behinddwalls
behinddwalls deleted the mnoah1/stovepipe-list-summary branch October 6, 2026 18:02

This branch was successfully deployed

1 active deployment
stack-rebase — b50531ac Deployed Oct 6, 2026 by mnoah1 via Rebase Stack #564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants